Re: Quick tips for code reviews

2018-04-30 Thread Na Li
+1 The most important item is to put review link to Jira. On Mon, Apr 30, 2018 at 11:22 AM, Alexander Kolbasov wrote: > +1 > > > On Apr 30, 2018, at 08:25, Sergio Pena wrote: > > > > Hey All, > > > > I just want to share with the community about

Re: Quick tips for code reviews

2018-04-30 Thread Alexander Kolbasov
+1 > On Apr 30, 2018, at 08:25, Sergio Pena wrote: > > Hey All, > > I just want to share with the community about some helpful tips when > submitting patches for review that are useful for reviewers: > > - Add a link to the review board on the JIRA related to the

Quick tips for code reviews

2018-04-30 Thread Sergio Pena
Hey All, I just want to share with the community about some helpful tips when submitting patches for review that are useful for reviewers: - Add a link to the review board on the JIRA related to the patch you're working on. - Add a link to the JIRA on the review board related to the