Hello Ashish, Thanks for your review. Currently, for sentry plugin, it won't depend on sentry-service-server which includes about 50 classes. I think SENTRY-1205 is the first step to refactor the module, and I'll improve it according to your evaluation for Kafka plugin later.
best regards, Colin Ma -----Original Message----- From: Ashish Singh [mailto:asi...@cloudera.com] Sent: Thursday, June 30, 2016 01:38 To: dev@sentry.apache.org Subject: Re: Status of SENTRY-1205 Hello Junjie, Thanks for the awesome work. I think one of the reasons to have separate server and client packages is to avoid plugins to include lots of dependencies that they do not need. Wondering if you did some evaluation on how this work changes required dependencies for plugins. I am planning to do some evaluation for Kafka plugin and will post my notes once I am done with it. On Tue, Jun 28, 2016 at 7:11 PM, Ma, Junjie <junjie...@intel.com> wrote: > Hi all, > > The SENTRY-1205 is finished and it's created for refactor the > sentry-provider-db and create sentry-service module. Currently, the > module sentry-provider-db includes all the codes for sentry server and > sentry client. To pull the client and server dependencies outside of > sentry-provider-db, sentry-service is created for this. > > The sentry-service includes sentry-service-common, > sentry-service-server and sentry-service-client. To minimize the > impact, the package name doesn't change, eg, you'll get the > org.apache.sentry.provider.db.service.persistent.SentryStore in > sentry-service-server module. It's kind of weird, and I think this can > be improved in the next step. > > For all sentry-binding dependency, they still dependent on > sentry-provider-db which will involve the sentry-service-client and > the server related code won't be involved. > For the module dependencies, the following things change: > sentry-provider-db depend on sentry-service-client > all sentry-tests depend on sentry-service-server > > I plan to merge this change with the master, feel free for any > comment, thanks. > > best regards, > Colin Ma > > -- Regards, Ashish
