Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

> On Dec. 19, 2016, 8:15 p.m., Hao Hao wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1720 > > > > > > It looks like fromNU

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review159644 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review159504 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/ --- (Updated Dec. 16, 2016, 9:17 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

> On Dec. 16, 2016, 8:18 p.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1449 > > > > > > I'd sugge

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review159486 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/ --- (Updated Dec. 16, 2016, 7:51 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

> On Dec. 13, 2016, 6:28 p.m., Alexander Kolbasov wrote: > > 1) Do we have any other users of fromNullCol or it should be removed as > > well? > > 2) This relates to SENTRY-1540 since now isMultiActionsSupported() becomes > > a real code and this changes the existing semantics some. Is it Ok or

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review159035 --- 1) Do we have any other users of fromNullCol or it should be remov

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/ --- (Updated Dec. 12, 2016, 7:57 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review158578 --- I mean convertToTSentryPrivilege() is similar. - Alexander Kolbas

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review158576 --- There is also toSentryPrivilege() with similar problem. And once t

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review158541 --- Ship it! Looks good - kalyan kumar kalvagadda On Dec. 8, 201