Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/#review133203 ---

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/#review133194 ---

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/ --- (Updated May 13, 2016, 4:20 p.m.) Review request for sentry, Dapeng Sun,

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/ --- (Updated May 12, 2016, 8:07 p.m.) Review request for sentry, Dapeng Sun,

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

> On May 12, 2016, 7:05 p.m., Gregory Chanan wrote: > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java, > > line 219 > > > > > > won't the solr

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/#review132962 ---

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

> On May 8, 2016, 4:35 a.m., Gregory Chanan wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java, > > line 115 > > > > > > did you want to deal with

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

> On May 8, 2016, 4:35 a.m., Gregory Chanan wrote: > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/CacheProvider.java, > > line 23 > > > > > > Shouldn't this be

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/ --- (Updated May 12, 2016, 9:03 a.m.) Review request for sentry, Dapeng Sun,

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/ --- (Updated May 12, 2016, 8:31 a.m.) Review request for sentry, Dapeng Sun,

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/ --- (Updated May 12, 2016, 8:06 a.m.) Review request for sentry, Dapeng Sun,

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

> On May 8, 2016, 4:35 a.m., Gregory Chanan wrote: > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/CacheProvider.java, > > line 23 > > > > > > Shouldn't this be

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

> On May 6, 2016, 8:34 a.m., Colin Ma wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java, > > line 123 > > > > > > For the filter,

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/#review132161 ---

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/ --- (Updated May 8, 2016, 1:15 a.m.) Review request for sentry, Dapeng Sun,

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/ --- (Updated May 8, 2016, 1:02 a.m.) Review request for sentry, Dapeng Sun,

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/#review132143 ---

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

> On May 6, 2016, 10 p.m., Gregory Chanan wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java, > > line 95 > > > > > > hmm...the

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/#review132087 ---

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

> On May 6, 2016, 8:39 a.m., Dapeng Sun wrote: > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryPrivilege.java, > > line 62 > > > > > >

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

> On May 6, 2016, 8:34 a.m., Colin Ma wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java, > > line 123 > > > > > > For the filter,

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/#review131996 ---

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/#review132002 ---

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

> On May 3, 2016, 12:21 a.m., Gregory Chanan wrote: > > Note: these comments are based on the assumption you are implementing this > > at the client layer. See my previous comments for why I think it's a > > better idea right now to do this at the ProviderBackend layer. As the code has