----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49392/#review140273 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java (line 23) <https://reviews.apache.org/r/49392/#comment205634> Use explicit import for packages? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java (line 60) <https://reviews.apache.org/r/49392/#comment205636> This test case is too long, would want to break it to several test cases? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java (line 61) <https://reviews.apache.org/r/49392/#comment205643> Should we also consider a concurrent test case which have multiple hms clients? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java (line 76) <https://reviews.apache.org/r/49392/#comment205638> Check for location information here? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java (line 83) <https://reviews.apache.org/r/49392/#comment205641> Add a case of create table without partition? - Hao Hao On June 29, 2016, 7:56 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49392/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 7:56 p.m.) > > > Review request for sentry, Anne Yu, Colin McCabe, and Hao Hao. > > > Bugs: Sentry-1324 > https://issues.apache.org/jira/browse/Sentry-1324 > > > Repository: sentry > > > Description > ------- > > Add sentry specific test cases to use NotificationLog using > DbNotificationListener > > > Diffs > ----- > > sentry-tests/sentry-tests-hive/pom.xml > 02bfa49c9513a36a93017c706375bf58d063d7d7 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 2add2d06ad1a54cf6746ac2e8d71ef3bc67899f7 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > f1e6d75b2ae8e20343ff49bd46ef254ed6320ad4 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/49392/diff/ > > > Testing > ------- > > All tests: new and regression pass. > > > Thanks, > > Sravya Tirukkovalur > >
