Re: Review Request 51848: Apply Checkstyle changes to the core

2016-10-18 Thread Colm O hEigeartaigh
> On Oct. 17, 2016, 8:34 p.m., Alexander Kolbasov wrote: > > My big concern with these changes is that they cause more deviation between > > trunk and sentry-ha branch where there are a lot of changes happening. The > > style changes are very useful but they cause quite complicated merges. I

Re: Review Request 51848: Apply Checkstyle changes to the core

2016-10-17 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51848/#review152947 --- My big concern with these changes is that they cause more

Review Request 51848: Apply Checkstyle changes to the core

2016-09-13 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51848/ --- Review request for sentry. Bugs: SENTRY-1470