Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2017-01-09 Thread Mat Crocker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/#review160917 --- minor nit, should be labeled "fields" not "feilds" Looks like

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/#review159252 --- It seems like you have the wrong diff here - you should have

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread Alexander Kolbasov
> On Dec. 6, 2016, 10:40 p.m., Vadim Spector wrote: > > sentry-service/sentry-service-common/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java, > > line 1031 > > > > > >

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/#review159246 ---

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/ --- (Updated Dec. 14, 2016, 10:23 p.m.) Review request for sentry, Alexander

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/ --- (Updated Dec. 14, 2016, 10:11 p.m.) Review request for sentry, Alexander

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread kalyan kumar kalvagadda
> On Dec. 6, 2016, 10:40 p.m., Vadim Spector wrote: > > sentry-service/sentry-service-common/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java, > > line 1031 > > > > > >

Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-06 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/ --- Review request for sentry, Alexander Kolbasov, Colin Ma, Hao Hao, Vamsee