Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

2017-01-09 Thread Hao Hao
> On Jan. 5, 2017, 3:49 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1624 > > > > > > Do you know why

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

2017-01-09 Thread Vamsee Yarlagadda
> On Jan. 5, 2017, 3:49 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1624 > > > > > > Do you know why

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

2017-01-09 Thread Vamsee Yarlagadda
> On Jan. 5, 2017, 3:49 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1624 > > > > > > Do you know why

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

2017-01-09 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54526/ --- (Updated Jan. 9, 2017, 8:15 p.m.) Review request for sentry, Alexander

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

2017-01-09 Thread Vamsee Yarlagadda
> On Jan. 9, 2017, 6:27 p.m., Mat Crocker wrote: > > should your || be an && ? > > this logic suggests its ok if the db is null, but the table name isn't The comment for this function says: "// Currently INSERT/SELECT/ALL are supported for Table and DB level privileges" So if the privilege

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

2017-01-04 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54526/ --- (Updated Jan. 5, 2017, 12:53 a.m.) Review request for sentry, Alexander

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

2016-12-08 Thread Alexander Kolbasov
> On Dec. 8, 2016, 9:32 p.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1607 > > > > > > So this

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

2016-12-08 Thread Vamsee Yarlagadda
> On Dec. 8, 2016, 9:32 p.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1607 > > > > > > So this

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

2016-12-08 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54526/#review158572 ---

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

2016-12-08 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54526/#review158542 --- >From what I understand from SENTRY-162, is that dropPrivilege

Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

2016-12-08 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54526/ --- Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar