Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-10 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/ --- (Updated Jan. 11, 2017, 1:13 a.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-10 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/ --- (Updated Jan. 10, 2017, 11:49 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-10 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/ --- (Updated Jan. 10, 2017, 9:48 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-10 Thread Hao Hao
> On Jan. 10, 2017, 8:24 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java, > > line 87 > > > > > > iWhat is the

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-10 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review161110 --- Fix it, then Ship it! sentry-provider/sentry-provider-db/src/m

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-09 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/ --- (Updated Jan. 10, 2017, 1:57 a.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-09 Thread Hao Hao
> On Jan. 6, 2017, 10:28 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java, > > lines 73-87 > > > > > > Just curiou

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-09 Thread Hao Hao
> On Jan. 6, 2017, 9:38 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java, > > line 82 > > > > > > What is the ide

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-09 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review161019 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-09 Thread Hao Hao
> On Jan. 6, 2017, 9:38 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java, > > line 161 > > > > > > Okease add javadocs for the new functions J

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-06 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review160776 --- Fix it, then Ship it! LGTM otherwise. sentry-provider/sentry-

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-06 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review159412 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-06 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review160748 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-06 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review160738 --- Ship it! After addressing the comment. - kalyan kumar kalvagad

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2017-01-06 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/#review160730 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

2016-12-13 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/ --- Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Vams