Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

2016-12-16 Thread Vadim Spector
> On Dec. 16, 2016, 7:05 p.m., Vadim Spector wrote: > > It is probably ok, but ... > > a) Did you investigate why service stayed alive? Perhaps, some knowledge > > about the implementation and its defficiencies to be gained there. Some > > unaccounted runaway threads? Or are we unable to termon

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

2016-12-16 Thread Misha Dmitriev
> On Dec. 16, 2016, 7:05 p.m., Vadim Spector wrote: > > It is probably ok, but ... > > a) Did you investigate why service stayed alive? Perhaps, some knowledge > > about the implementation and its defficiencies to be gained there. Some > > unaccounted runaway threads? Or are we unable to termon

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

2016-12-16 Thread Vadim Spector
> On Dec. 16, 2016, 7:05 p.m., Vadim Spector wrote: > > It is probably ok, but ... > > a) Did you investigate why service stayed alive? Perhaps, some knowledge > > about the implementation and its defficiencies to be gained there. Some > > unaccounted runaway threads? Or are we unable to termon

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

2016-12-16 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54808/#review159488 --- Ship it! - kalyan kumar kalvagadda On Dec. 16, 2016, 7:23 a.m

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

2016-12-16 Thread Alexander Kolbasov
> On Dec. 16, 2016, 7:05 p.m., Vadim Spector wrote: > > It is probably ok, but ... > > a) Did you investigate why service stayed alive? Perhaps, some knowledge > > about the implementation and its defficiencies to be gained there. Some > > unaccounted runaway threads? Or are we unable to termon

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

2016-12-16 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54808/#review159478 --- Ship it! It is probably ok, but ... a) Did you investigate why

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

2016-12-16 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54808/#review159475 --- Ship it! Ship It! - Vamsee Yarlagadda On Dec. 16, 2016, 7:23

Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

2016-12-15 Thread Misha Dmitriev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54808/#review159415 --- Ship it! Ship It! - Misha Dmitriev On Dec. 16, 2016, 7:23 a.

Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

2016-12-15 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54808/ --- Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda,