Re: Review Request 55190: SENTRY-1583: Refactor ZK/Curator code

2017-01-06 Thread Alexander Kolbasov
> On Jan. 7, 2017, 4:25 a.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java, > > line 251 > > > > > > Just curious to know

Re: Review Request 55190: SENTRY-1583: Refactor ZK/Curator code

2017-01-06 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55190/#review160806 --- Fix it, then Ship it! LGTM otherwise.

Re: Review Request 55190: SENTRY-1583: Refactor ZK/Curator code

2017-01-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55190/ --- (Updated Jan. 6, 2017, 6:06 a.m.) Review request for sentry, Colin Ma, Misha

Re: Review Request 55190: SENTRY-1583: Refactor ZK/Curator code

2017-01-05 Thread Alexander Kolbasov
> On Jan. 6, 2017, 5:20 a.m., Misha Dmitriev wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java, > > line 173 > > > > > > I wonder why this

Re: Review Request 55190: SENTRY-1583: Refactor ZK/Curator code

2017-01-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55190/ --- (Updated Jan. 6, 2017, 2:14 a.m.) Review request for sentry, Colin Ma, Misha

Re: Review Request 55190: SENTRY-1583: Refactor ZK/Curator code

2017-01-05 Thread Misha Dmitriev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55190/#review160624 ---