Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/#review166288 --- Ship it! Ship It! sentry-provider/sentry-provider-db/src/main

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/#review166268 --- Ship it! Ship It! - Hao Hao On Feb. 21, 2017, 11:30 p.m., Le

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/ --- (Updated Feb. 21, 2017, 3:30 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/ --- (Updated Feb. 21, 2017, 2:53 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

> On Feb. 21, 2017, 2:40 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 492 > > > > > > Can you please also log

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/#review166238 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/#review166242 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/#review166234 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/ --- (Updated Feb. 21, 2017, 1:47 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/ --- (Updated Feb. 21, 2017, 1:27 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

> On Feb. 17, 2017, 5:44 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryChange.java, > > line 23 > > > > > > Nit - since this i

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/#review166015 --- Fix it, then Ship it! Ship It! sentry-provider/sentry-provide

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/ --- (Updated Feb. 17, 2017, 5:26 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

> On Feb. 16, 2017, 10:47 p.m., Alexander Kolbasov wrote: > > I would consider refactoring this a bit. IMO it is better to have > > SentryStore as just a DB access layer class and have services like this > > cleaner to be created outside of SentryStore by consumers so whoever sets > > up Sentr

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

> On Feb. 16, 2017, 11:13 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 2559 > > > > > > We may still want to

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

> On Feb. 16, 2017, 10:47 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 89 > > > > > > That's wrong - isLeader is a s

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/#review165908 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/#review165907 --- I would consider refactoring this a bit. IMO it is better to have

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/ --- (Updated Feb. 16, 2017, 3:37 p.m.) Review request for sentry, Alexander Kolbaso

Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/ --- Review request for sentry and Hao Hao. Bugs: SENTRY-1611 https://issues.apa