Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/#review169909 --- Ship it! Ship It! - Alexander Kolbasov On March 23, 2017, 1:

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/ --- (Updated March 23, 2017, 1:06 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/#review169846 --- Ship it! The changes are good, but do you need to address SENTR

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

> On March 11, 2017, 12:12 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/MissingConfigurationException.java > > Lines 24 (patched) > > > > > >

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

> On March 14, 2017, 3:10 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceClientDefaultImpl.java > > Line 118 (original), 125 (patched) > > > > >

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

> On March 9, 2017, 12:40 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConfigInterface.java > > Lines 40 (patched) > > > > >

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

> On March 13, 2017, 8:25 p.m., Vadim Spector wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceClientDefaultImpl.java > > Line 53 (original), 57 (patched) > > > > > > co

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/ --- (Updated March 22, 2017, 11:05 p.m.) Review request for sentry, Alexander Kolba

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/#review168858 --- Fix it, then Ship it! Ship It! sentry-core/sentry-core-common

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

> On March 13, 2017, 8:25 p.m., Vadim Spector wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceClientDefaultImpl.java > > Line 53 (original), 57 (patched) > > > > > > co

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

> On March 13, 2017, 8:25 p.m., Vadim Spector wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConfigInterface.java > > Lines 31 (patched) > > > > > >

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/ --- (Updated March 13, 2017, 11:47 p.m.) Review request for sentry, Alexander Kolba

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/ --- (Updated March 13, 2017, 10:05 p.m.) Review request for sentry, Alexander Kolba

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/#review168795 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/ --- (Updated March 13, 2017, 4:35 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/#review168685 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/ --- (Updated March 10, 2017, 8:15 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/#review168380 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/ --- (Updated March 8, 2017, 6:41 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

> On March 7, 2017, 1:17 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConfigInterface.java > > Lines 27 (patched) > > > > >

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/ --- (Updated March 7, 2017, 6:51 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/#review168066 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

> On Feb. 27, 2017, 12:52 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConfigInterface.java, > > line 26 > > > > > > Th

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/ --- (Updated Feb. 28, 2017, 1:24 a.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56954/ --- (Updated Feb. 28, 2017, 1:14 a.m.) Review request for sentry, Alexander Kolbaso