Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/#review169982 --- Ship it! Ship It! - Alexander Kolbasov On March 24, 2017, 1:

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- (Updated March 24, 2017, 1:12 a.m.) Review request for sentry. Repository: se

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

> On March 23, 2017, 1:34 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 49 (patched) > > > > > > I had this comment before -

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

> On March 23, 2017, 1:34 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java > > Lines 42 (patched) > > > > > > Would it make sense to add

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

> On March 23, 2017, 1:34 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > > Lines 77 (patched) > > > > > > Since there is no concurren

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- (Updated March 24, 2017, 12:53 a.m.) Review request for sentry. Repository: s

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/#review169817 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- (Updated March 22, 2017, 11:08 p.m.) Review request for sentry. Repository: s

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- (Updated March 14, 2017, 8:56 p.m.) Review request for sentry. Repository: se

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

> On March 14, 2017, 12:48 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > > Lines 77 (patched) > > > > > > Why are we using a new loc

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

> On March 14, 2017, 12:48 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 59 (patched) > > > > > > Can we relax the return typ

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- (Updated March 14, 2017, 6:59 p.m.) Review request for sentry. Repository: se

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

> On March 14, 2017, 12:48 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3406 (patched) > > > > > >

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

> On March 14, 2017, 12:48 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3298 (patched) > > > > > >

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

> On March 14, 2017, 12:48 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 30 (patched) > > > > > > The first sentence should b

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/#review168846 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- (Updated March 10, 2017, 11:14 p.m.) Review request for sentry. Repository: s

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- (Updated March 10, 2017, 10:29 p.m.) Review request for sentry. Repository: s

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

> On March 6, 2017, 10:38 p.m., Lei Xu wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/DeltaRetriever.java > > Lines 35 (patched) > > > > > > If we retrieve `Perm` and `Path` separately,

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/#review168057 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- (Updated March 2, 2017, 7:39 a.m.) Review request for sentry. Repository: sen

Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- Review request for sentry. Summary (updated) - SENTRY-1613: Ad