Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-04-06 Thread Lei Xu
> On April 6, 2017, 7:05 a.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Lines 360 (patched) > > > > > > comment mentioned to return false if failed, but

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-04-06 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review171081 ---

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-04-04 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review171052 --- Ship it! Ship It! - Alexander Kolbasov On April 4, 2017,

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-04-04 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review171020 --- Fix it, then Ship it! Ship It!

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-03-27 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/ --- (Updated March 27, 2017, 5:24 p.m.) Review request for sentry, Alexander

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-03-27 Thread Lei Xu
> On March 24, 2017, 4:55 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Lines 182 (patched) > > > > > > What does it mean for path elements

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-03-24 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review170064 ---

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-03-22 Thread Lei Xu
> On March 14, 2017, 1:49 p.m., Hao Hao wrote: > > Can you add test cases in the intergation test as well, > > TestHDFSIntegrationAdvanced. To ensure cases such as for managed/unmanaged > > table we get expected output. > > Also, it looks like the tests are not all green. Would you mind take a

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-03-22 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/ --- (Updated March 22, 2017, 2:27 p.m.) Review request for sentry, Alexander

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-03-14 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review168939 --- Can you add test cases in the intergation test as well,

Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-03-13 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/ --- Review request for sentry, Alexander Kolbasov and Hao Hao. Bugs: SENTRY-1644