Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/ --- (Updated April 10, 2017, 3:47 p.m.) Review request for sentry. Bugs:

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread Lei Xu
> On April 10, 2017, 12:58 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java > > Lines 75 (patched) > > > > > >

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread Lei Xu
> On April 10, 2017, 2:57 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2592 (patched) > > > > > >

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/#review171494 --- Fix it, then Ship it! Ship It!

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread Lei Xu
> On April 10, 2017, 12:58 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java > > Lines 87 (patched) > >

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/#review171464 ---

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/ --- (Updated April 10, 2017, 12:54 p.m.) Review request for sentry. Bugs:

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread Lei Xu
> On April 10, 2017, 11:37 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2581 (patched) > > > > > > Can

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/#review171458 --- Fix it, then Ship it!

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/#review171454 --- Ship it! Ship It! - Na Li On April 8, 2017, 12:38 a.m., Lei

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread Lei Xu
> On April 10, 2017, 9:25 a.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java > > Lines 87 (patched) > > > > > > Is it

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-10 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/#review171444 ---

Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

2017-04-07 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/ --- Review request for sentry. Bugs: SENTRY-1643