Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-06-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- (Updated June 6, 2017, 12:58 a.m.) Review request for sentry, Brian Towles, Hao

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-06-05 Thread Alexander Kolbasov
> On June 5, 2017, 9:54 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientFactory.java > > Lines 88-89 (patched) > >

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-06-05 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review176955 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-06-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- (Updated June 5, 2017, 8:14 a.m.) Review request for sentry, Brian Towles, Hao

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-06-04 Thread Alexander Kolbasov
> On June 1, 2017, 8:32 p.m., kalyan kumar kalvagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceClientFactory.java > > Lines 76-103 (original), 73-82 (patched) > >

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-06-04 Thread Alexander Kolbasov
- Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review176454 --- On May 26, 2017, 8:53 p.m., Alexander Kolbasov wrote

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-06-01 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review176454 --- I have a general comment on kerberos when connection pool is enabl

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-26 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review176226 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- (Updated May 26, 2017, 8:52 p.m.) Review request for sentry, Brian Towles, Hao

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-24 Thread Alexander Kolbasov
> On May 24, 2017, 12:10 p.m., kalyan kumar kalvagadda wrote: > > Seems like you have an emty comment. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review175920

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-24 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review175920 --- - kalyan kumar kalvagadda On May 24, 2017, 7:49 a.m., Alexander

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-24 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- (Updated May 24, 2017, 7:49 a.m.) Review request for sentry, Brian Towles, Hao

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-22 Thread Alexander Kolbasov
> On May 18, 2017, 8:18 p.m., Na Li wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/RetryClientInvocationHandler.java > > Line 113 (original), 112 (patched) > > > > > >

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-22 Thread Alexander Kolbasov
> On May 22, 2017, 5:54 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > > Lines 35 (patched) > > > > > > How are ch

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-22 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review175433 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-18 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review175427 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-18 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review175425 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-16 Thread Alexander Kolbasov
> On May 16, 2017, 10:42 p.m., Sergio Pena wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportPool.java > > Lines 102 (patched) > > > > > > You may use conf

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-16 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- (Updated May 17, 2017, 4:42 a.m.) Review request for sentry, Brian Towles, Hao

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-16 Thread Alexander Kolbasov
> On May 16, 2017, 10:42 p.m., Sergio Pena wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportPool.java > > Lines 94 (patched) > > > > > > The class annotate

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-16 Thread Alexander Kolbasov
> On May 17, 2017, 12:27 a.m., kalyan kumar kalvagadda wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportPool.java > > Lines 135 (patched) > > > > > > lifo

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-16 Thread Alexander Kolbasov
> On May 16, 2017, 9:07 p.m., Lei Xu wrote: > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListenerBase.java > > Line 362 (original), 362 (patched) > >

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-16 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review175145 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-16 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review175162 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-16 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review175158 --- sentry-binding/sentry-binding-hive-common/src/main/java/org/apach

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-13 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- (Updated May 13, 2017, 10:01 p.m.) Review request for sentry, Brian Towles, Hao

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-13 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- (Updated May 13, 2017, 9:43 p.m.) Review request for sentry, Brian Towles, Hao

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-12 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- (Updated May 12, 2017, 7:06 a.m.) Review request for sentry, Brian Towles, Hao

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-12 Thread Alexander Kolbasov
> On May 12, 2017, 2:26 a.m., Vamsee Yarlagadda wrote: > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListenerBase.java > > Line 362 (original), 362 (patched) > >

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-11 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review174745 --- sentry-binding/sentry-binding-hive-common/src/main/java/org/apach

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-11 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- (Updated May 11, 2017, 7:17 a.m.) Review request for sentry, Brian Towles, Hao

Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

2017-05-10 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- Review request for sentry, Brian Towles, Hao Hao, kalyan kumar kalvagadda, Na Li