Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

> On Sept. 1, 2017, 7 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java > > Line 142 (original), 143 (patched) > > > > > > Applic

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

> On Sept. 1, 2017, 7 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java > > Line 142 (original), 143 (patched) > > > > > > Applic

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62007/#review184387 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

> On Sept. 1, 2017, 5:01 p.m., Sergio Pena wrote: > > The patch looks good. But just wonder, how does this patch have a memory > > improvement? I see the big change is just to return an ArrayList instead of > > a HashSet in the getPathStrings(). How does this make us better? Hi Sergio. HashSet

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62007/#review184369 --- Ship it! Ship It! - Vamsee Yarlagadda On Aug. 31, 2017, 4:14

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62007/#review184366 --- Ship it! The patch looks good. But just wonder, how does this p

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62007/#review184312 --- Ship it! As we just discussed, the ideal solution to this probl

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62007/#review184304 --- Maybe I don't understand all the details, but here is what I think

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62007/ --- (Updated Aug. 31, 2017, 4:14 p.m.) Review request for sentry, Arjun Mishra, Bri

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62007/ --- (Updated Aug. 31, 2017, 6:54 a.m.) Review request for sentry, Arjun Mishra, Bri

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

> On Aug. 31, 2017, 6:28 a.m., Misha Dmitriev wrote: > > In general I wonder whether instead of the old Set<> we should now use > > Collection<> rather than the more explicit List<>. I think using a > > supertype like Collection<> makes sense only if it's used for a method > > parameter that c

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62007/#review184238 --- In general I wonder whether instead of the old Set<> we should now

Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62007/ --- Review request for sentry, Arjun Mishra, Brian Towles, Misha Dmitriev, Na Li, Se