Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2018-01-04 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Jan. 4, 2018, 5:05 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2018-01-04 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Jan. 4, 2018, 4:43 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2018-01-04 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Jan. 4, 2018, 4:40 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-28 Thread kalyan kumar kalvagadda via Review Board
> On Dec. 28, 2017, 5:21 p.m., kalyan kumar kalvagadda wrote: > > I have couple of comments on the approach taken. Before going into that, I > > would re-iterate couple of assumptions that HMSFollower has taken > > > > 1. Method getCurrentNotificationEventId on Hmsclient would always return >

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-28 Thread Arjun Mishra via Review Board
> On Dec. 28, 2017, 5:21 p.m., kalyan kumar kalvagadda wrote: > > I have couple of comments on the approach taken. Before going into that, I > > would re-iterate couple of assumptions that HMSFollower has taken > > > > 1. Method getCurrentNotificationEventId on Hmsclient would always return >

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-28 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194585 --- I have couple of comments on the approach taken. Before going into

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-25 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194500 --- Ship it! Ship It! - Vadim Spector On Dec. 25, 2017, 10:49 p.

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-25 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Dec. 25, 2017, 10:49 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-25 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Dec. 25, 2017, 10:48 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-24 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194489 --- Seems like I have no problems with the code once my comments in th

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-23 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194479 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-23 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Dec. 24, 2017, 1:50 a.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-23 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194476 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-23 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194475 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-23 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194474 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-23 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194472 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2017-12-22 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar kalvag