Re: svn commit: r1712718 - /serf/trunk/buckets/allocator.c

2015-11-05 Thread Ivan Zhakov
On 6 November 2015 at 08:43, Greg Stein wrote: > On Thu, Nov 5, 2015 at 9:29 AM, Ivan Zhakov wrote: > >> > On Thu, Nov 5, 2015 at 1:40 AM, wrote: >> > >> >> Author: ivan >> >> Date: Thu Nov 5 07:40:58 2015 >> >> New Revision: 1712718 >> >> >> >> URL: http://svn.apache.org/viewvc?rev=1712718&vie

Re: svn commit: r1712831 - in /serf/trunk/test/MockHTTPinC: MockHTTP.h MockHTTP_server.c

2015-11-05 Thread Lieven Govaerts
If it makes a difference or things easier, I can bring the test framework under the serf umbrella. It's not gonna live on its own and It seems that you ​ ​ guys are doing a lot of work on it... Lieven ​ Op donderdag 5 november 2015 heeft het volgende geschreven: > Author: rhuijben > Date: Thu

Re: svn commit: r1712718 - /serf/trunk/buckets/allocator.c

2015-11-05 Thread Greg Stein
On Thu, Nov 5, 2015 at 9:29 AM, Ivan Zhakov wrote: > > On Thu, Nov 5, 2015 at 1:40 AM, wrote: > > > >> Author: ivan > >> Date: Thu Nov 5 07:40:58 2015 > >> New Revision: 1712718 > >> > >> URL: http://svn.apache.org/viewvc?rev=1712718&view=rev > >> Log: > >> Add another diagnostic macro SERF__DE

svn commit: r1712848 - /serf/trunk/test/MockHTTPinC/MockHTTP_server.c

2015-11-05 Thread rhuijben
Author: rhuijben Date: Thu Nov 5 19:13:45 2015 New Revision: 1712848 URL: http://svn.apache.org/viewvc?rev=1712848&view=rev Log: * test/MockHTTPinC/MockHTTP_server.c (cloneResponse): Make apr pool debugging a bit happier. Modified: serf/trunk/test/MockHTTPinC/MockHTTP_server.c Modified: s

Re: Dedicated mailing list for buildbot notifications?

2015-11-05 Thread C. Michael Pilato
Oh, yes PLEASE. +1. Amen. And all that stuff. On Thu, Nov 5, 2015 at 1:26 PM, Lieven Govaerts wrote: > On Thu, Nov 5, 2015 at 4:34 PM, Bert Huijben wrote: > > > > > >> -Original Message- > >> From: Ivan Zhakov [mailto:i...@visualsvn.com] > >> Sent: donderdag 5 november 2015 16:31 > >

svn commit: r1712844 - /serf/trunk/protocols/http2_protocol.c

2015-11-05 Thread rhuijben
Author: rhuijben Date: Thu Nov 5 18:41:00 2015 New Revision: 1712844 URL: http://svn.apache.org/viewvc?rev=1712844&view=rev Log: * protocols/http2_protocol.c (http2_protocol_cleanup): Tweak comment as it might give a bad hint where to look to reviewers. Modified: serf/trunk/protocols/h

svn commit: r1712843 - /serf/trunk/protocols/http2_protocol.c

2015-11-05 Thread rhuijben
Author: rhuijben Date: Thu Nov 5 18:38:43 2015 New Revision: 1712843 URL: http://svn.apache.org/viewvc?rev=1712843&view=rev Log: Resolve the most likely (small) memory leak in the http2 protocol implementation. * protocols/http2_protocol.c (http2_bucket_processor): Add forward definition. (h

Re: Dedicated mailing list for buildbot notifications?

2015-11-05 Thread Lieven Govaerts
On Thu, Nov 5, 2015 at 4:34 PM, Bert Huijben wrote: > > >> -Original Message- >> From: Ivan Zhakov [mailto:i...@visualsvn.com] >> Sent: donderdag 5 november 2015 16:31 >> To: dev@serf.apache.org >> Subject: Dedicated mailing list for buildbot notifications? >> >> I think it's worth to crea

FW: buildbot success in ASF Buildbot on serf-x64-macosx

2015-11-05 Thread Bert Huijben
For whoever is not following the brand new notificati...@serf.apache.org list: The bots just returned to the green status. Sorry for all the noise... Thanks, Bert > -Original Message- > From: build...@apache.org [mailto:build...@apache.org] > Sent: donderdag 5 november 2015 19:1

svn commit: r1712839 - /serf/trunk/outgoing.c

2015-11-05 Thread rhuijben
Author: rhuijben Date: Thu Nov 5 18:09:05 2015 New Revision: 1712839 URL: http://svn.apache.org/viewvc?rev=1712839&view=rev Log: Make the test suite a bit happier by moving the code that handles certain specific error codes to the central error handling of read_from_connection(), to also include

svn commit: r1712831 - in /serf/trunk/test/MockHTTPinC: MockHTTP.h MockHTTP_server.c

2015-11-05 Thread rhuijben
Author: rhuijben Date: Thu Nov 5 17:36:59 2015 New Revision: 1712831 URL: http://svn.apache.org/viewvc?rev=1712831&view=rev Log: Resolve some warnings in the mockhttp server by returing port numbers as apr_port_t. * test/MockHTTPinC/MockHTTP.h (mhServerPortNr, mhProxyPortNr, mhServerByID

svn commit: r1712829 - /serf/trunk/test/test_ssl.c

2015-11-05 Thread ivan
Author: ivan Date: Thu Nov 5 17:35:09 2015 New Revision: 1712829 URL: http://svn.apache.org/viewvc?rev=1712829&view=rev Log: * test/test_ssl.c (extract_cert_from_pem): Destroy PEMBKT bucket after using to avoid unfreed memory warnings. Modified: serf/trunk/test/test_ssl.c Modified: ser

buildbot failure in ASF Buildbot on serf-windows

2015-11-05 Thread buildbot
The Buildbot has detected a new failure on builder serf-windows while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-windows/builds/257 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-w2k3-ra Build Reason: The AnyBranchScheduler s

svn commit: r1712827 - /serf/trunk/test/test_ssl.c

2015-11-05 Thread ivan
Author: ivan Date: Thu Nov 5 17:29:35 2015 New Revision: 1712827 URL: http://svn.apache.org/viewvc?rev=1712827&view=rev Log: Resolve unfreed warnings in test_ssl_init() test. * test/test_ssl.c (test_ssl_init): Do not share the same bucket as streams for encrypt and decrypt buckets otherwise

buildbot exception in ASF Buildbot on serf-windows

2015-11-05 Thread buildbot
The Buildbot has detected a build exception on builder serf-windows while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-windows/builds/256 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-w2k3-ra Build Reason: The AnyBranchSchedul

svn commit: r1712825 - /serf/trunk/outgoing.c

2015-11-05 Thread rhuijben
Author: rhuijben Date: Thu Nov 5 17:26:06 2015 New Revision: 1712825 URL: http://svn.apache.org/viewvc?rev=1712825&view=rev Log: While checking if there is data waiting to be written also write out the encrypted buffer even when the bucket reported that it needs a read first... perhaps it had ask

svn commit: r1712809 - /serf/trunk/test/test_buckets.c

2015-11-05 Thread ivan
Author: ivan Date: Thu Nov 5 16:24:02 2015 New Revision: 1712809 URL: http://svn.apache.org/viewvc?rev=1712809&view=rev Log: Add test for optimization implemented in r1712806. * test/test_buckets.c (test_aggregate_buckets): Test reading from aggregate bucket with empty buckets. Modified:

svn commit: r1712806 - /serf/trunk/buckets/aggregate_buckets.c

2015-11-05 Thread rhuijben
Author: rhuijben Date: Thu Nov 5 16:15:53 2015 New Revision: 1712806 URL: http://svn.apache.org/viewvc?rev=1712806&view=rev Log: Make the aggregate bucket's peek and read a bit more agressive in cleaning up when it encounters a 100% empty bucket at the front. The sooner buckets are destroyed, th

RE: Dedicated mailing list for buildbot notifications?

2015-11-05 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: donderdag 5 november 2015 16:31 > To: dev@serf.apache.org > Subject: Dedicated mailing list for buildbot notifications? > > I think it's worth to create separate mailing list for buildbot > notifications. It's h

svn commit: r1712797 - /serf/trunk/test/test_buckets.c

2015-11-05 Thread ivan
Author: ivan Date: Thu Nov 5 15:32:17 2015 New Revision: 1712797 URL: http://svn.apache.org/viewvc?rev=1712797&view=rev Log: Follow-up to r1712795: Remove unused function. * test/test_buckets.c (prepend_magic): Remove. Modified: serf/trunk/test/test_buckets.c Modified: serf/trunk/test/te

Re: svn commit: r1712718 - /serf/trunk/buckets/allocator.c

2015-11-05 Thread Ivan Zhakov
> On Thu, Nov 5, 2015 at 1:40 AM, wrote: > >> Author: ivan >> Date: Thu Nov 5 07:40:58 2015 >> New Revision: 1712718 >> >> URL: http://svn.apache.org/viewvc?rev=1712718&view=rev >> Log: >> Add another diagnostic macro SERF__DEBUG_USE_AFTER_FREE to detect usage of >> bucket allocator after it dest

Dedicated mailing list for buildbot notifications?

2015-11-05 Thread Ivan Zhakov
I think it's worth to create separate mailing list for buildbot notifications. It's hard to follow commits and discussions when they are mixed with multiple notifications from buildbot about test failures. -- Ivan Zhakov

svn commit: r1712795 - /serf/trunk/test/test_buckets.c

2015-11-05 Thread ivan
Author: ivan Date: Thu Nov 5 15:23:18 2015 New Revision: 1712795 URL: http://svn.apache.org/viewvc?rev=1712795&view=rev Log: Add test for problem in aggregate buckets fixed in r1712790. * test/test_buckets.c (test_aggregate_buckets): Test prepend and then append to aggregate bucket. Modified:

svn commit: r1712790 - /serf/trunk/buckets/aggregate_buckets.c

2015-11-05 Thread rhuijben
Author: rhuijben Date: Thu Nov 5 15:02:58 2015 New Revision: 1712790 URL: http://svn.apache.org/viewvc?rev=1712790&view=rev Log: Make serf_bucket_aggregate_prepend() behave properly when prepending an bucket to an empty list. It forgot to update last, which broke the next append. Found by: r171

svn commit: r1712786 - /serf/trunk/outgoing.c

2015-11-05 Thread rhuijben
Author: rhuijben Date: Thu Nov 5 14:36:59 2015 New Revision: 1712786 URL: http://svn.apache.org/viewvc?rev=1712786&view=rev Log: Following up on r1712776, reduce the strict dependency on polling for cleanup of finished request by also explicitly setting the writing status to DONE via a hold_open

buildbot failure in ASF Buildbot on serf-sparc64-solaris

2015-11-05 Thread buildbot
The Buildbot has detected a new failure on builder serf-sparc64-solaris while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-sparc64-solaris/builds/214 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-sparc-solaris Build Reason: Th

buildbot failure in ASF Buildbot on serf-x64-macosx

2015-11-05 Thread buildbot
The Buildbot has detected a new failure on builder serf-x64-macosx while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx/builds/230 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: The AnyBr

buildbot failure in ASF Buildbot on serf-windows

2015-11-05 Thread buildbot
The Buildbot has detected a new failure on builder serf-windows while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-windows/builds/249 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-w2k3-ra Build Reason: The AnyBranchScheduler s

buildbot failure in ASF Buildbot on serf-x64-macosx-apr1.5

2015-11-05 Thread buildbot
The Buildbot has detected a new failure on builder serf-x64-macosx-apr1.5 while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-apr1.5/builds/213 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Rea

svn commit: r1712776 - in /serf/trunk: connection_request.c outgoing.c serf_private.h

2015-11-05 Thread rhuijben
Author: rhuijben Date: Thu Nov 5 14:05:02 2015 New Revision: 1712776 URL: http://svn.apache.org/viewvc?rev=1712776&view=rev Log: Extend request write state to an enum that exactly tracks what state we are in. This allows determining whether it is safe to clear the request pool and when we certain

buildbot failure in ASF Buildbot on serf-x64-macosx-default-openssl

2015-11-05 Thread buildbot
The Buildbot has detected a new failure on builder serf-x64-macosx-default-openssl while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-default-openssl/builds/216 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-maco

Re: svn commit: r1712718 - /serf/trunk/buckets/allocator.c

2015-11-05 Thread Greg Stein
Seems this should be tried straight into the allocator debugging, rather than separately configurable. Use-after-free is quite bad, so I think it should always die right away. Your work on reporting unfreed items is a bit different, as some applications *may* choose to leave some allocations until

buildbot failure in ASF Buildbot on serf-x64-macosx-apr2.0-dev

2015-11-05 Thread buildbot
The Buildbot has detected a new failure on builder serf-x64-macosx-apr2.0-dev while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/serf-x64-macosx-apr2.0-dev/builds/207 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs B