[GitHub] coveralls commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration

coveralls commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/490#issuecomment-355727974 [](https://coveralls.io/b

[GitHub] coveralls commented on issue #487: [SCB-166] Metrics Support HealthCheck

coveralls commented on issue #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#issuecomment-355722095 [](https://coveralls.io/builds/14927359) Cover

[GitHub] coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#issuecomment-355721880 [](ht

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160016136 ## File path: metrics/metrics-common/src/main/java/io/servicecomb/metrics/common/HealthC

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160016106 ## File path: samples/metrics-extend-healthcheck/src/main/java/io/servicecomb/samples/me

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160016112 ## File path: samples/metrics-extend-healthcheck/src/main/java/io/servicecomb/samples/me

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160016085 ## File path: samples/metrics-extend-healthcheck/pom.xml ## @@ -0,0 +1,53 @@ +

[GitHub] zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

zhengyangyong commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160016073 ## File path: metrics/metrics-core/src/main/java/io/servicecomb/metrics/core/health/Defa

[GitHub] wujimin commented on a change in pull request #482: JAV-579 support dataStrArray

wujimin commented on a change in pull request #482: JAV-579 support dataStrArray URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/482#discussion_r160015868 ## File path: swagger/swagger-generator/generator-core/src/main/java/io/servicecomb/swagger/extend/annot

[GitHub] coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

coveralls commented on issue #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#issuecomment-355718284 [](ht

[GitHub] liubao68 commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

liubao68 commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r160013520 ## File path: metrics/metrics-common/src/main/java/io/servicecomb/metrics/common/HealthCheckR

[GitHub] liubao68 opened a new pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center

liubao68 opened a new pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492 Follow this checklist to help us incorporate your contribution quickly and easily

[GitHub] wujimin commented on issue #485: [SCB-176] Generate traceId

wujimin commented on issue #485: [SCB-176] Generate traceId URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/485#issuecomment-355711634 we always generate traceId, trace solution will based on this please ensure zipkin no problem, then i will approve this PR ---

[GitHub] liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159877061 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/c

[GitHub] liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159877427 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/c

[GitHub] liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159877164 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/c

[GitHub] liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

liubao68 commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159877061 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistry/c

[GitHub] coveralls commented on issue #491: SCB-179 support -(java identifiers) as parameter name with RequestParam

coveralls commented on issue #491: SCB-179 support -(java identifiers) as parameter name with RequestParam URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/491#issuecomment-355543306 [](https://coveral

[GitHub] acsukesh opened a new pull request #491: SCB-179 support -(java identifiers) as parameter name with RequestParam

acsukesh opened a new pull request #491: SCB-179 support -(java identifiers) as parameter name with RequestParam URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/491 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make

[GitHub] yangbor commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2

yangbor commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488#issuecomment-355528416 @WillemJiang The integration test is fixed. This

[GitHub] coveralls commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2

coveralls commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488#issuecomment-355528157 [](https://coveralls.io/builds/14914717)

[GitHub] coveralls commented on issue #104: [SCB-183] callback cleanup on connection loss

coveralls commented on issue #104: [SCB-183] callback cleanup on connection loss URL: https://github.com/apache/incubator-servicecomb-saga/pull/104#issuecomment-355527143 [](https://coveralls.io/builds/14914608) Cover

[GitHub] seanyinx opened a new pull request #104: [SCB-183] callback cleanup on connection loss

seanyinx opened a new pull request #104: [SCB-183] callback cleanup on connection loss URL: https://github.com/apache/incubator-servicecomb-saga/pull/104 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](http

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159840995 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159840126 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159842886 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159841366 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159839958 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159841081 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159843224 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159842972 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159842616 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159840446 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159839799 ## File path: dynamic-config/config-apollo/src/mai

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159839601 ## File path: dynamic-config/config-apollo/pom.xml

[GitHub] eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159839297 ## File path: dynamic-config/config-apollo/pom.xml

[GitHub] seanyinx closed pull request #102: SCB-157 Updated the pom setting for apache release

seanyinx closed pull request #102: SCB-157 Updated the pom setting for apache release URL: https://github.com/apache/incubator-servicecomb-saga/pull/102 This is an automated message from the Apache Git Service. To respond to

[GitHub] mojieshui commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration

mojieshui commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/490#issuecomment-355513038 @wujimin @liubao68 @WillemJiang --

[GitHub] mojieshui opened a new pull request #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration

mojieshui opened a new pull request #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/490 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure t

[GitHub] little-cui closed pull request #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

little-cui closed pull request #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244 This is a PR merged from a forked repository. As GitHub hides the origina

[GitHub] codecov-io commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

codecov-io commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244#issuecomment-355509350 # [Codecov](https://codecov.io/gh/apache/incubator-

[GitHub] coveralls commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

coveralls commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244#issuecomment-355512610 [![Coverage Status](https://coveralls.io/builds/

[GitHub] coveralls commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

coveralls commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244#issuecomment-355509456 [![Coverage Status](https://coveralls.io/builds/

[GitHub] codecov-io commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

codecov-io commented on issue #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244#issuecomment-355509350 # [Codecov](https://codecov.io/gh/apache/incubator-

[GitHub] WillemJiang commented on issue #485: [SCB-176] Generate traceId

WillemJiang commented on issue #485: [SCB-176] Generate traceId URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/485#issuecomment-355508581 Just a quick question, what's the relationship between this change and the old zipkin tracing code. AFAIK, ZipkinTracingHand

[GitHub] little-cui opened a new pull request #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function.

little-cui opened a new pull request #244: SCB-182 Registry client option 'WithStrKey' will set the wrong key as using non-copy string function. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/244 (cherry picked from commit 894c251) Follow this checkl

[GitHub] WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159832585 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistr

[GitHub] WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159832477 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistr

[GitHub] WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances

WillemJiang commented on a change in pull request #486: [SCB-165] Service registry not given proper instances URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/486#discussion_r159832305 ## File path: service-registry/src/main/java/io/servicecomb/serviceregistr

[GitHub] WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r159831873 ## File path: samples/metrics-extend-healthcheck/src/main/java/io/servicecomb/samples/metr

[GitHub] WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r159831628 ## File path: samples/metrics-extend-healthcheck/src/main/java/io/servicecomb/samples/metr

[GitHub] WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r159831312 ## File path: samples/metrics-extend-healthcheck/pom.xml ## @@ -0,0 +1,53 @@ + +

[GitHub] WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck

WillemJiang commented on a change in pull request #487: [SCB-166] Metrics Support HealthCheck URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/487#discussion_r159831078 ## File path: metrics/metrics-core/src/main/java/io/servicecomb/metrics/core/health/Defaul

[GitHub] WillemJiang commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2

WillemJiang commented on issue #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488#issuecomment-355502907 @yangbor ZipkinTracingIntegrationTest is failed, can you double check it? -

[GitHub] WillemJiang closed pull request #103: [SCB-167] proper connection & disconnection

WillemJiang closed pull request #103: [SCB-167] proper connection & disconnection URL: https://github.com/apache/incubator-servicecomb-saga/pull/103 This is an automated message from the Apache Git Service. To respond to the

[GitHub] coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

coveralls commented on issue #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#issuecomment-355499238 [](https://co

[GitHub] eric-lee-ltk commented on issue #103: [SCB-167] proper connection & disconnection

eric-lee-ltk commented on issue #103: [SCB-167] proper connection & disconnection URL: https://github.com/apache/incubator-servicecomb-saga/pull/103#issuecomment-355498726 LGTM This is an automated message from the Apache Gi

[GitHub] little-cui closed pull request #243: SCB-181 Unused instance index key is stored in backend.

little-cui closed pull request #243: SCB-181 Unused instance index key is stored in backend. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/243 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] coveralls commented on issue #243: SCB-181 Unused instance index key is stored in backend.

coveralls commented on issue #243: SCB-181 Unused instance index key is stored in backend. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/243#issuecomment-355496987 [](https://coveralls.io/builds/1

[GitHub] codecov-io commented on issue #243: SCB-181 Unused instance index key is stored in backend.

codecov-io commented on issue #243: SCB-181 Unused instance index key is stored in backend. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/243#issuecomment-355497057 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/243?src=pr&el=

[GitHub] lijasonvip opened a new pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ?

lijasonvip opened a new pull request #489: [WIP] SCB-36 Support dynamic configuration for chassis by integrating with ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/489 ?Apollo. Signed-off-by: lijasonvip Follow this checklist to help us incorporate y

[GitHub] yangbor opened a new pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2

yangbor opened a new pull request #488: [SCB-172] upgrade zipkin libraries to zipkin2 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/488 Upgraded zipkin to zipkin2:2.4.2 and zipkin-reporter to zipkin-reporter2:2.2.2. The zipkin2.Span changed a lot from the old zi