[GitHub] wujimin commented on a change in pull request #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer?

wujimin commented on a change in pull request #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/578#discussion_r173383416 ## File path: common/common-rest/src/main/java/org/apache/ser

[GitHub] wujimin commented on a change in pull request #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer?

wujimin commented on a change in pull request #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/578#discussion_r173383434 ## File path: common/common-rest/src/main/java/org/apache/ser

[GitHub] coveralls commented on issue #577: [SCB-352] refactor QpsControllerManager, support operation level qps controll on provider side

coveralls commented on issue #577: [SCB-352] refactor QpsControllerManager, support operation level qps controll on provider side URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/577#issuecomment-371106161 [![Coverage Status](https://coveralls.io/builds/15889527/

[GitHub] yhs0092 commented on a change in pull request #577: [SCB-352] refactor QpsControllerManager, support operation level qps controll on provider side

yhs0092 commented on a change in pull request #577: [SCB-352] refactor QpsControllerManager, support operation level qps controll on provider side URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/577#discussion_r173378612 ## File path: handlers/handler-flowco

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Third Attempt

+1 All testings are pass! -- Original -- From: Mohammad Asif Siddiqui Date: Thu,Mar 8,2018 8:02 PM To: dev Subject: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Third Attempt

[GitHub] liubao68 commented on issue #579: [SCB-29] add README document for config-apollo

liubao68 commented on issue #579: [SCB-29] add README document for config-apollo URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371726422 The referenced manual still use io.servicecomb package? please changed it -

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0

-1 for vote, as the we need to fix the sample readme issue which blocks the user to run the samples by just reading the readme. I checked the released kit and run the build from src, it looks good. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chi

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1

-1 for vote, as the we need to fix the sample readme issue which blocks the user to run the samples by just reading the readme. I checked the released kit and run the build from src, it looks good. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Ch

[GitHub] coveralls commented on issue #580: [SCB-6] add metrics samples readme

coveralls commented on issue #580: [SCB-6] add metrics samples readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/580#issuecomment-371715156 [](https://coveralls.io/builds/15888401) Coverage

[GitHub] zhengyangyong opened a new pull request #580: [SCB-6] add metrics samples readme

zhengyangyong opened a new pull request #580: [SCB-6] add metrics samples readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/580 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] M

[GitHub] coveralls commented on issue #147: SCB-330 add guides to run executable alpha server

coveralls commented on issue #147: SCB-330 add guides to run executable alpha server URL: https://github.com/apache/incubator-servicecomb-saga/pull/147#issuecomment-371706466 [](https://coveralls.io/builds/15887904)

[GitHub] coveralls commented on issue #579: [SCB-29] add README document for config-apollo

coveralls commented on issue #579: [SCB-29] add README document for config-apollo URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649 [](https://coveralls.io/builds/15887521)

[GitHub] coveralls commented on issue #579: [SCB-29] add README document for config-apollo

coveralls commented on issue #579: [SCB-29] add README document for config-apollo URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649 [](https://coveralls.io/builds/15887469)

[GitHub] eric-lee-ltk opened a new pull request #147: SCB-330 add guides to run executable alpha server

eric-lee-ltk opened a new pull request #147: SCB-330 add guides to run executable alpha server URL: https://github.com/apache/incubator-servicecomb-saga/pull/147 Signed-off-by: Eric Lee Follow this checklist to help us incorporate your contribution quickly and easily: - [ ]

[GitHub] coveralls commented on issue #579: [SCB-29] add README document for config-apollo

coveralls commented on issue #579: [SCB-29] add README document for config-apollo URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649 [](https://coveralls.io/builds/15887129)

[GitHub] coveralls commented on issue #579: [SCB-29] add README document for config-apollo

coveralls commented on issue #579: [SCB-29] add README document for config-apollo URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649 [](https://coveralls.io/builds/15887105)

[GitHub] coveralls commented on issue #579: [SCB-29] add README document for config-apollo

coveralls commented on issue #579: [SCB-29] add README document for config-apollo URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649 [](https://coveralls.io/builds/15887093)

[GitHub] coveralls commented on issue #579: [SCB-29] add README document for config-apollo

coveralls commented on issue #579: [SCB-29] add README document for config-apollo URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649 [](https://coveralls.io/builds/15887078)

[GitHub] lijasonvip opened a new pull request #579: [SCB-29] add README document for config-apollo

lijasonvip opened a new pull request #579: [SCB-29] add README document for config-apollo URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/579 Signed-off-by: lijasonvip Follow this checklist to help us incorporate your contribution quickly and easily:

[VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0

Hi All, This is a call for Vote to release Apache ServiceComb Saga (Incubating) version 0.1.0 Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12342353 Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecom

[VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1

Hi All, This is a call for Vote to release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0-m1 Release Notes : https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md Release Candidate : https://dist.apache.org/repos/dist/dev/incubat

[GitHub] coveralls commented on issue #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer?

coveralls commented on issue #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/578#issuecomment-371492044 [](https://coverall

[GitHub] jeho0815 opened a new pull request #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer?

jeho0815 opened a new pull request #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/578 ?Filter?so some body can do something through writing other Filters around args coding Follow th

[VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Third Attempt

Hi All, This is a call for Vote to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1 (third release candidate). Release Notes : https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md Release Candidate : https:

[GitHub] liubao68 commented on a change in pull request #577: [SCB-352] refactor QpsControllerManager, support operation level qps controll on provider side

liubao68 commented on a change in pull request #577: [SCB-352] refactor QpsControllerManager, support operation level qps controll on provider side URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/577#discussion_r173107595 ## File path: handlers/handler-flowc

[GitHub] yangbor commented on a change in pull request #572: [SCB-370] Improve latency and max precision

yangbor commented on a change in pull request #572: [SCB-370] Improve latency and max precision URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/572#discussion_r173105633 ## File path: metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/Met

Re: 回复： [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

Hi Willem, This is not an issue, this is more like a suggestion to handle the configuration in a better way, as the values of SC_IP can still be changed in js file as per our Readme. So IMO we don't need to add this in Known Issues list. Anyhow I have created a JIRA for this [1] to t

[GitHub] yangbor commented on a change in pull request #572: [SCB-370] Improve latency and max precision

yangbor commented on a change in pull request #572: [SCB-370] Improve latency and max precision URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/572#discussion_r173104487 ## File path: metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/Met

Re: ��������������������������� [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

[1] https://github.com/apache/incubator-servicecomb-service-center/pull/300 On 2018/03/08 09:13:03, Mohammad Asif Siddiqui wrote: > Thanks All for your feedback, here is the PR [1] to fix the above mentioned > issues. > > We are cancelling this VOTE now, we will be re-intiate the VOTE mail

[GitHub] little-cui closed pull request #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files

little-cui closed pull request #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/300 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

Re: ��������� [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

Thanks All for your feedback, here is the PR [1] to fix the above mentioned issues. We are cancelling this VOTE now, we will be re-intiate the VOTE mail with a new release candidate. Regards Asif On 2018/03/08 07:49:01, Mohammad Asif Siddiqui wrote: > Thanks YangBo and Cuiyihu

[GitHub] lijasonvip opened a new pull request #41: [SCB-210] update document for apollo configuration item

lijasonvip opened a new pull request #41: [SCB-210] update document for apollo configuration item URL: https://github.com/apache/incubator-servicecomb-website/pull/41 Signed-off-by: lijasonvip This is an automated message fr

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1

+0 No Opinion. Below Checks Done, No problem found: 1.Release both windows and linux from source 2.Verified the windows release using Java Chassis BMI sample and Java Chassis SpringMvc Integration Test 3.Verified the linux release by see port is listen and can curl page content from fronten

[GitHub] codecov-io commented on issue #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files

codecov-io commented on issue #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/300#issuecomment-371422143 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-cen

[GitHub] coveralls commented on issue #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files

coveralls commented on issue #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/300#issuecomment-371422212 [](https:

Re: 回复： [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

Hi Asif， Please create a JIRA for checking the apiList.js issue. Then we can add this known issue to the release note and address it in m2 release. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Thu

[GitHub] coveralls commented on issue #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files

coveralls commented on issue #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/300#issuecomment-371422212 [](https:

[GitHub] codecov-io commented on issue #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files

codecov-io commented on issue #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/300#issuecomment-371422143 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-cen

[GitHub] WillemJiang closed pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

WillemJiang closed pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is dis

[GitHub] coveralls commented on issue #575: [SCB-369] Extract info from spectator measurement

coveralls commented on issue #575: [SCB-369] Extract info from spectator measurement URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/575#issuecomment-371080516 [](https://coveralls.io/builds/15870056)

[GitHub] asifdxtreme opened a new pull request #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files

asifdxtreme opened a new pull request #300: SCB-317 Merge frontend conf to app.conf and fix shebang line issue in sh files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/300 Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] wujimin commented on a change in pull request #575: [SCB-369] Extract info from spectator measurement

wujimin commented on a change in pull request #575: [SCB-369] Extract info from spectator measurement URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/575#discussion_r173089137 ## File path: foundations/foundation-metrics/src/test/java/org/apache/servicecomb/