[GitHub] WillemJiang commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating

2018-03-10 Thread GitBox
WillemJiang commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating URL: https://github.com/apache/incubator-servicecomb-service-center/pull/301#issuecomment-372096333 @asifdxtreme I just submitted a new PR#302 for this change. Please take a

[GitHub] coveralls commented on issue #302: SCB-380 Added incubating to the release kit name

2018-03-10 Thread GitBox
coveralls commented on issue #302: SCB-380 Added incubating to the release kit name URL: https://github.com/apache/incubator-servicecomb-service-center/pull/302#issuecomment-372096354 [![Coverage

[GitHub] codecov-io commented on issue #302: SCB-380 Added incubating to the release kit name

2018-03-10 Thread GitBox
codecov-io commented on issue #302: SCB-380 Added incubating to the release kit name URL: https://github.com/apache/incubator-servicecomb-service-center/pull/302#issuecomment-372096341 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/302?src=pr=h1)

[GitHub] WillemJiang commented on issue #302: SCB-380 Added incubating to the release kit name

2018-03-10 Thread GitBox
WillemJiang commented on issue #302: SCB-380 Added incubating to the release kit name URL: https://github.com/apache/incubator-servicecomb-service-center/pull/302#issuecomment-372096048 NOTE, this change may affect to the docker image start up script.

[GitHub] WillemJiang opened a new pull request #302: SCB-380 Added incubating to the release kit name

2018-03-10 Thread GitBox
WillemJiang opened a new pull request #302: SCB-380 Added incubating to the release kit name URL: https://github.com/apache/incubator-servicecomb-service-center/pull/302 * Changed the kit name to apache-servicecomb-incubating-service-center-xxx * Reduced the binary name to

[GitHub] coveralls commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating

2018-03-10 Thread GitBox
coveralls commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating URL: https://github.com/apache/incubator-servicecomb-service-center/pull/301#issuecomment-372094104 [![Coverage

[GitHub] codecov-io commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating

2018-03-10 Thread GitBox
codecov-io commented on issue #301: SCB-317 Update the release scripts to replace incubator with incubating URL: https://github.com/apache/incubator-servicecomb-service-center/pull/301#issuecomment-372094088 #

[GitHub] asifdxtreme opened a new pull request #301: SCB-317 Update the release scripts to replace incubator with incubating

2018-03-10 Thread GitBox
asifdxtreme opened a new pull request #301: SCB-317 Update the release scripts to replace incubator with incubating URL: https://github.com/apache/incubator-servicecomb-service-center/pull/301 Follow this checklist to help us incorporate your contribution quickly and easily: - [x]

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0

2018-03-10 Thread Mohammad Asif Siddiqui
Hi All, We are cancelling this vote thread as some changes needs to be done in Readme for samples. We will re-intiate a separate vote thread for new release candidate. Thanks all for your support. Regards Asif On 2018/03/08 17:10:38, Mohammad Asif Siddiqui

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Third Attempt

2018-03-10 Thread Mohammad Asif Siddiqui
-1 The release name should contain apache-incubating name, currently its apache incubator. On 2018/03/08 12:02:24, Mohammad Asif Siddiqui wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1

[GitHub] WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-10 Thread GitBox
WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372032679 Tested on macOSX, the test was blocked when starting the contianer,

[GitHub] WillemJiang closed pull request #581: [SCB-378] add readme document for samples

2018-03-10 Thread GitBox
WillemJiang closed pull request #581: [SCB-378] add readme document for samples URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/581 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jeho0815 commented on a change in pull request #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer?

2018-03-10 Thread GitBox
jeho0815 commented on a change in pull request #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/578#discussion_r173623397 ## File path:

[GitHub] WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-10 Thread GitBox
WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372032679 Tested on macOSX, the test is blocked, so we cannot merge for

[GitHub] coveralls commented on issue #581: [SCB-378] add readme document for samples

2018-03-10 Thread GitBox
coveralls commented on issue #581: [SCB-378] add readme document for samples URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/581#issuecomment-371753636 [![Coverage Status](https://coveralls.io/builds/15907318/badge)](https://coveralls.io/builds/15907318)

[GitHub] lijasonvip commented on a change in pull request #581: [SCB-378] add readme document for samples

2018-03-10 Thread GitBox
lijasonvip commented on a change in pull request #581: [SCB-378] add readme document for samples URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/581#discussion_r173617546 ## File path: samples/auth-sample/README.md ## @@ -0,0 +1,82 @@ +##

[GitHub] coveralls commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-10 Thread GitBox
coveralls commented on issue #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372017538 [![Coverage

[GitHub] zhengyangyong opened a new pull request #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-10 Thread GitBox
zhengyangyong opened a new pull request #584: [SCB-382] upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584 ?s-on setting Signed-off-by: zhengyangyong

[GitHub] wujimin commented on a change in pull request #583: [SCB-381] Fix foundation-vertx UT failure

2018-03-10 Thread GitBox
wujimin commented on a change in pull request #583: [SCB-381] Fix foundation-vertx UT failure URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/583#discussion_r173616568 ## File path: foundations/foundation-vertx/pom.xml ## @@ -53,4 +53,21 @@