[VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Fifth Attempt

2018-03-26 Thread Mohammad Asif Siddiqui
Hi All, This is a call for a Vote to release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0-m1 Release Notes : https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/etc/releaseNotes.md Release Candidate :

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-26 Thread Mohammad Asif Siddiqui
Hi All, We are closing of this vote as some issues needs to be fixed in this release, we will fix and re-initiate the voting in a seperate thread. Regards Asif On 2018/03/26 13:40:42, Willem Jiang wrote: > -1, > > I checked the source code, we have some

[GitHub] wujimin commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate

2018-03-26 Thread GitBox
wujimin commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#discussion_r177293321 ## File path:

[GitHub] wujimin commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate

2018-03-26 Thread GitBox
wujimin commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#discussion_r177291103 ## File path:

[GitHub] wujimin commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate

2018-03-26 Thread GitBox
wujimin commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#discussion_r177290894 ## File path:

[GitHub] WillemJiang closed pull request #163: [SCB-437] Add a FAQ list

2018-03-26 Thread GitBox
WillemJiang closed pull request #163: [SCB-437] Add a FAQ list URL: https://github.com/apache/incubator-servicecomb-saga/pull/163 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] codecov-io commented on issue #318: SCB-432 Support using default tls cipher suites implements

2018-03-26 Thread GitBox
codecov-io commented on issue #318: SCB-432 Support using default tls cipher suites implements URL: https://github.com/apache/incubator-servicecomb-service-center/pull/318#issuecomment-376370413 #

[GitHub] coveralls commented on issue #318: SCB-432 Support using default tls cipher suites implements

2018-03-26 Thread GitBox
coveralls commented on issue #318: SCB-432 Support using default tls cipher suites implements URL: https://github.com/apache/incubator-servicecomb-service-center/pull/318#issuecomment-376369813 [![Coverage

[GitHub] codecov-io commented on issue #318: SCB-432 Support using default tls cipher suites implements

2018-03-26 Thread GitBox
codecov-io commented on issue #318: SCB-432 Support using default tls cipher suites implements URL: https://github.com/apache/incubator-servicecomb-service-center/pull/318#issuecomment-376370413 #

[GitHub] coveralls commented on issue #318: SCB-432 Support using default tls cipher suites implements

2018-03-26 Thread GitBox
coveralls commented on issue #318: SCB-432 Support using default tls cipher suites implements URL: https://github.com/apache/incubator-servicecomb-service-center/pull/318#issuecomment-376369813 [![Coverage

[GitHub] little-cui opened a new pull request #318: SCB-432 Support using default tls cipher suites implements

2018-03-26 Thread GitBox
little-cui opened a new pull request #318: SCB-432 Support using default tls cipher suites implements URL: https://github.com/apache/incubator-servicecomb-service-center/pull/318 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure

[GitHub] wujimin commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate

2018-03-26 Thread GitBox
wujimin commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#discussion_r177284840 ## File path:

?????? Propose adding maven archetypes in Java Chassis

2018-03-26 Thread bismy
Agreed. We can add a brief readme to each generated projects and write some user guides how to use archetypes. -- -- ??: "Zen Lin"; : 2018??3??26??(??) 7:12 ??: "dev";

[GitHub] wujimin commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate

2018-03-26 Thread GitBox
wujimin commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#discussion_r177284484 ## File path:

[GitHub] coveralls commented on issue #163: [SCB-437] Add a FAQ list

2018-03-26 Thread GitBox
coveralls commented on issue #163: [SCB-437] Add a FAQ list URL: https://github.com/apache/incubator-servicecomb-saga/pull/163#issuecomment-376367269 [![Coverage Status](https://coveralls.io/builds/16192608/badge)](https://coveralls.io/builds/16192608) Coverage increased

[GitHub] wujimin commented on a change in pull request #607: [SCB-406] Chassis must support standard parameter validation handler

2018-03-26 Thread GitBox
wujimin commented on a change in pull request #607: [SCB-406] Chassis must support standard parameter validation handler URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/607#discussion_r177283452 ## File path:

[GitHub] wujimin commented on a change in pull request #607: [SCB-406] Chassis must support standard parameter validation handler

2018-03-26 Thread GitBox
wujimin commented on a change in pull request #607: [SCB-406] Chassis must support standard parameter validation handler URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/607#discussion_r177282866 ## File path:

[GitHub] chanjarster opened a new pull request #163: [SCB-437] Add a FAQ list

2018-03-26 Thread GitBox
chanjarster opened a new pull request #163: [SCB-437] Add a FAQ list URL: https://github.com/apache/incubator-servicecomb-saga/pull/163 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] wujimin commented on a change in pull request #607: [SCB-406] Chassis must support standard parameter validation handler

2018-03-26 Thread GitBox
wujimin commented on a change in pull request #607: [SCB-406] Chassis must support standard parameter validation handler URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/607#discussion_r177279891 ## File path:

[GitHub] coveralls commented on issue #162: SCB-410 Alpha Service upgraded to Spring Boot 2.0

2018-03-26 Thread GitBox
coveralls commented on issue #162: SCB-410 Alpha Service upgraded to Spring Boot 2.0 URL: https://github.com/apache/incubator-servicecomb-saga/pull/162#issuecomment-376207936 [![Coverage Status](https://coveralls.io/builds/16190675/badge)](https://coveralls.io/builds/16190675)

Re: Does servicecomb support spring boot 2(or spring 5)?

2018-03-26 Thread Willem Jiang
FYI, I'm working Upgrading the Spring Boot 2[1] in the ServiceComb saga project. Most work will be done shortly. [1]https://issues.apache.org/jira/browse/SCB-410 Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo:

[GitHub] coveralls commented on issue #162: SCB-410 Alpha Service upgraded to Spring Boot 2.0

2018-03-26 Thread GitBox
coveralls commented on issue #162: SCB-410 Alpha Service upgraded to Spring Boot 2.0 URL: https://github.com/apache/incubator-servicecomb-saga/pull/162#issuecomment-376207936 [![Coverage Status](https://coveralls.io/builds/16181209/badge)](https://coveralls.io/builds/16181209)

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-26 Thread Willem Jiang
-1, I checked the source code, we have some files[1][2] which use the old license header. We also have a minor sample error[3] need to be fixed. [1] https://github.com/apache/incubator-servicecomb-java-chassis/pull/620/commits/2770d4218a650386ae4536704d30915fa9d96a8a [2]

[GitHub] WillemJiang opened a new pull request #162: SCB-410 Alpha Service upgraded to Spring Boot 2.0

2018-03-26 Thread GitBox
WillemJiang opened a new pull request #162: SCB-410 Alpha Service upgraded to Spring Boot 2.0 URL: https://github.com/apache/incubator-servicecomb-saga/pull/162 Support to build the Alpha Server with Spring Boot 2.0 by using -Pspring-boot-2 TODO: Upgrade the demos to Spring Boot 2.0

[GitHub] WillemJiang closed pull request #161: SCB-433 Updated the docker running setting

2018-03-26 Thread GitBox
WillemJiang closed pull request #161: SCB-433 Updated the docker running setting URL: https://github.com/apache/incubator-servicecomb-saga/pull/161 This is an automated message from the Apache Git Service. To respond to the

[GitHub] WillemJiang opened a new pull request #161: SCB-433 Updated the docker running setting

2018-03-26 Thread GitBox
WillemJiang opened a new pull request #161: SCB-433 Updated the docker running setting URL: https://github.com/apache/incubator-servicecomb-saga/pull/161 This is an automated message from the Apache Git Service. To respond

[GitHub] WillemJiang closed pull request #621: [SCB-434] fix jaxrs-provider sample dependency

2018-03-26 Thread GitBox
WillemJiang closed pull request #621: [SCB-434] fix jaxrs-provider sample dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/621 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] WillemJiang closed pull request #620: SCB-431 Added Rat Check to TravisCI

2018-03-26 Thread GitBox
WillemJiang closed pull request #620: SCB-431 Added Rat Check to TravisCI URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/620 This is an automated message from the Apache Git Service. To respond to the

Re: Propose adding maven archetypes in Java Chassis

2018-03-26 Thread Zen Lin
Thanks to yangyong, to my opinion, I quite agree with you, It should be useful to users and the community, and what about others's opinion? 2018-03-26 15:07 GMT+08:00 郑扬勇 : > Hi Zen Lin: >If user create a blank maven project and want import chassis, he must > do these

[GitHub] coveralls commented on issue #621: [SCB-434] fix jaxrs-provider sample dependency

2018-03-26 Thread GitBox
coveralls commented on issue #621: [SCB-434] fix jaxrs-provider sample dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/621#issuecomment-376087455 [![Coverage Status](https://coveralls.io/builds/16176565/badge)](https://coveralls.io/builds/16176565)

[GitHub] coveralls commented on issue #621: [SCB-434] fix jaxrs-provider sample dependency

2018-03-26 Thread GitBox
coveralls commented on issue #621: [SCB-434] fix jaxrs-provider sample dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/621#issuecomment-376087455 [![Coverage Status](https://coveralls.io/builds/16173673/badge)](https://coveralls.io/builds/16173673)

[GitHub] zhengyangyong opened a new pull request #621: [SCB-434] fix jaxrs-provider sample dependency

2018-03-26 Thread GitBox
zhengyangyong opened a new pull request #621: [SCB-434] fix jaxrs-provider sample dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/621 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your

Re: Propose adding maven archetypes in Java Chassis

2018-03-26 Thread ??????
Hi Zen Lin: If user create a blank maven project and want import chassis, he must do these steps: 1. Our chassis support multi provider and transport, also support integration with spring boot, he must copy right dependencies into pom, and let "java-chassis-dependencies" manage versions.

[GitHub] coveralls commented on issue #620: SCB-431 Added Rat Check to TravisCI

2018-03-26 Thread GitBox
coveralls commented on issue #620: SCB-431 Added Rat Check to TravisCI URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/620#issuecomment-376062482 [![Coverage Status](https://coveralls.io/builds/16172634/badge)](https://coveralls.io/builds/16172634)

[GitHub] WillemJiang opened a new pull request #620: SCB-431 Added Rat Check to TravisCI

2018-03-26 Thread GitBox
WillemJiang opened a new pull request #620: SCB-431 Added Rat Check to TravisCI URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/620 Clean up the old License header Add the Rat Check to Travis CI This