[GitHub] coveralls commented on issue #641: [SCB-470] add spring boot starter provider archetype

coveralls commented on issue #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#issuecomment-380649944 [](https://coveralls.io/builds/164762

[GitHub] wujimin commented on issue #627: [SCB-292] chassis support standard parameter validation

wujimin commented on issue #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#issuecomment-380714285 need to resolve the problem that consumer can not get validate message. and then merge this PR. ---

[GitHub] wujimin commented on issue #642: [SCB-468] Add notice for vertx 3.5.1

wujimin commented on issue #642: [SCB-468] Add notice for vertx 3.5.1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/642#issuecomment-380715186 https://github.com/vert-x3/vertx-web/issues/906 will rollback to 3.5.0

[GitHub] wujimin commented on issue #641: [SCB-470] add spring boot starter provider archetype

wujimin commented on issue #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#issuecomment-380715499 please paste warning check This is an au

[GitHub] wujimin commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype

wujimin commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r180996593 ## File path: archetypes/business-service-spring-boot-starter/pom.xml #

[GitHub] wujimin commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype

wujimin commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181000647 ## File path: archetypes/business-service-spring-boot-starter/pom.xml #

[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype

zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181004010 ## File path: archetypes/business-service-spring-boot-starter/pom.xml ###

[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype

zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181008181 ## File path: archetypes/business-service-spring-boot-starter/pom.xml ###

[GitHub] yangbor opened a new pull request #328: [SCB-479] Add proxy to service-center in frontend

yangbor opened a new pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328 Add a proxy in the frontend server, and make the httpService js to access the service-center through the proxy. Fol

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380728892 This is a work in progress, please do not merge it right now. TODO: 1. Update related documentations

[GitHub] yangbor commented on issue #642: [SCB-468] Add notice for vertx 3.5.1

yangbor commented on issue #642: [SCB-468] Add notice for vertx 3.5.1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/642#issuecomment-380730496 Close this PR due to rollback to vertx 3.5.0 This is an a

[GitHub] yangbor closed pull request #642: [SCB-468] Add notice for vertx 3.5.1

yangbor closed pull request #642: [SCB-468] Add notice for vertx 3.5.1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/642 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] zhfeng opened a new pull request #170: SCB-480 Update to add the timeout in the GrpcTxEvent

zhfeng opened a new pull request #170: SCB-480 Update to add the timeout in the GrpcTxEvent URL: https://github.com/apache/incubator-servicecomb-saga/pull/170 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue]

[GitHub] coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend

coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735106 [](https://coveralls.io/builds/164

[GitHub] codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend

codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735171 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr&el=h1) R

Re: Ask for Help of ServiceComb Saga

Hi Willem, It looks like an issue [1] when I working with the timeout scenario and I just open the PR [2] for fixing. please can you take a look ? and it is blocking my work with the timeout now. Thanks a lot ! [1] https://issues.apache.org/jira/browse/SCB-480 [2] https://github.com/apache/incub

[GitHub] coveralls commented on issue #170: SCB-480 Update to add the timeout in the GrpcTxEvent

coveralls commented on issue #170: SCB-480 Update to add the timeout in the GrpcTxEvent URL: https://github.com/apache/incubator-servicecomb-saga/pull/170#issuecomment-380736703 [](https://coveralls.io/builds/16477856)

Re: Ask for Help of ServiceComb Saga

I will take a look at shortly. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Thu, Apr 12, 2018 at 5:15 PM, Zheng Feng wrote: > Hi Willem, > > It looks like an issue [1] when I working with the tim

[GitHub] WillemJiang closed pull request #170: SCB-480 Update to add the timeout in the GrpcTxEvent

WillemJiang closed pull request #170: SCB-480 Update to add the timeout in the GrpcTxEvent URL: https://github.com/apache/incubator-servicecomb-saga/pull/170 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pro

[GitHub] xuyiyun0929 opened a new pull request #646: [SCB-478]revert netty's version to 4.1.17 and vertx's version to 3.5.0

xuyiyun0929 opened a new pull request #646: [SCB-478]revert netty's version to 4.1.17 and vertx's version to 3.5.0 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/646 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mak

[GitHub] coveralls commented on issue #646: [SCB-478]revert netty's version to 4.1.17 and vertx's version to 3.5.0

coveralls commented on issue #646: [SCB-478]revert netty's version to 4.1.17 and vertx's version to 3.5.0 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/646#issuecomment-380749379 [](https://coverall

[GitHub] zhengyangyong commented on issue #641: [SCB-470] add spring boot starter provider archetype

zhengyangyong commented on issue #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#issuecomment-380776823 ![2xmf 3 c6xrfe 57v61gv_a](https://user-images.githubusercontent.com/374335/38675320-e2b12332-3e89-

[GitHub] liubao68 opened a new pull request #647: [SCB-481]Fix qps handler compatible issues due to assumption to schema ids not contains dot

liubao68 opened a new pull request #647: [SCB-481]Fix qps handler compatible issues due to assumption to schema ids not contains dot URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/647 Follow this checklist to help us incorporate your contribution quickly and eas

[GitHub] coveralls commented on issue #647: [SCB-481]Fix qps handler compatible issues due to assumption to schema ids not contains dot

coveralls commented on issue #647: [SCB-481]Fix qps handler compatible issues due to assumption to schema ids not contains dot URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/647#issuecomment-380805380 [![Coverage Status](https://coveralls.io/builds/16482051/bad

[GitHub] codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin

codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034141 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=h1) Repor

[GitHub] coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin

coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034081 [](https://coveralls.io/builds/16482321)

[GitHub] zhfeng opened a new pull request #171: [SCB-300] acceptance test of the timeout

zhfeng opened a new pull request #171: [SCB-300] acceptance test of the timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/171 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://

Re: Ask for Help of ServiceComb Saga

Thanks Willem and it looks good to me. The acceptance test of the timeout has been raised in the PR [1]. [1] https://github.com/apache/incubator-servicecomb-saga/pull/171 2018-04-12 17:25 GMT+08:00 Willem Jiang : > I will take a look at shortly. > > > Willem Jiang > > Blog: http://willemjiang.bl

[GitHub] coveralls commented on issue #171: [SCB-300] acceptance test of the timeout

coveralls commented on issue #171: [SCB-300] acceptance test of the timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/171#issuecomment-380818154 [](https://coveralls.io/builds/16482774) Coverage d

[GitHub] coveralls commented on issue #171: [SCB-300] acceptance test of the timeout

coveralls commented on issue #171: [SCB-300] acceptance test of the timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/171#issuecomment-380818158 [](https://coveralls.io/builds/16482774) Coverage d

[GitHub] WillemJiang commented on a change in pull request #171: [SCB-300] acceptance test of the timeout

WillemJiang commented on a change in pull request #171: [SCB-300] acceptance test of the timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/171#discussion_r181239974 ## File path: acceptance-tests/acceptance-pack/src/test/resources/booking_timeout.btm

[GitHub] wujimin commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype

wujimin commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181258826 ## File path: archetypes/business-service-spring-boot-starter/pom.xml #

[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype

zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181260091 ## File path: archetypes/business-service-spring-boot-starter/pom.xml ###

[GitHub] WillemJiang commented on a change in pull request #171: [SCB-300] acceptance test of the timeout

WillemJiang commented on a change in pull request #171: [SCB-300] acceptance test of the timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/171#discussion_r181262422 ## File path: acceptance-tests/acceptance-pack/src/test/resources/booking_timeout.btm

[GitHub] WillemJiang closed pull request #171: [SCB-300] acceptance test of the timeout

WillemJiang closed pull request #171: [SCB-300] acceptance test of the timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/171 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] liubao68 closed pull request #646: [SCB-478]revert netty's version to 4.1.17 and vertx's version to 3.5.0

liubao68 closed pull request #646: [SCB-478]revert netty's version to 4.1.17 and vertx's version to 3.5.0 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/646 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed be

[GitHub] liubao68 closed pull request #645: [SCB-477] sdk guava's version need to update to 19.0

liubao68 closed pull request #645: [SCB-477] sdk guava's version need to update to 19.0 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/645 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

Re: Ask for Help of ServiceComb Saga

Yeah, it's great. It demonstrate how to inject the failure without changing the code. I just merge the patch. Looking forward the other scenarios :) Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On

[GitHub] WillemJiang commented on issue #642: [SCB-468] Add notice for vertx 3.5.1

WillemJiang commented on issue #642: [SCB-468] Add notice for vertx 3.5.1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/642#issuecomment-380990758 We need to revisit this issue once we upgrade the vertx version. -

[GitHub] WillemJiang commented on issue #640: SCB-457 demostrate how to run spring boot/non spring boot application with gradle

WillemJiang commented on issue #640: SCB-457 demostrate how to run spring boot/non spring boot application with gradle URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/640#issuecomment-380990979 @liubao68 @wujimin Please review this PR. --

[GitHub] codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin

codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034141 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=h1) Repor

[GitHub] coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin

coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034081 [](https://coveralls.io/builds/16495155)

[GitHub] wujimin commented on issue #646: [SCB-478]revert netty's version to 4.1.17 and vertx's version to 3.5.0

wujimin commented on issue #646: [SCB-478]revert netty's version to 4.1.17 and vertx's version to 3.5.0 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/646#issuecomment-380993579 https://github.com/vert-x3/vertx-web/issues/906 3.5.1 bug already fixed with 3.6.

[GitHub] liubao68 commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype

liubao68 commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181268093 ## File path: archetypes/business-service-spring-boot-starter/README.md ##

[GitHub] liubao68 commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype

liubao68 commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181269775 ## File path: archetypes/business-service-spring-boot-starter/src/main/resourc

[GitHub] liubao68 commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype

liubao68 commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181269775 ## File path: archetypes/business-service-spring-boot-starter/src/main/resourc

[GitHub] eric-lee-ltk commented on a change in pull request #647: [SCB-481]Fix qps handler compatible issues due to assumption to schema ids not contains dot

eric-lee-ltk commented on a change in pull request #647: [SCB-481]Fix qps handler compatible issues due to assumption to schema ids not contains dot URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/647#discussion_r181271866 ## File path: handlers/handler-flow

[GitHub] WillemJiang commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype

WillemJiang commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181272667 ## File path: archetypes/business-service-spring-boot-starter/README.md ###

[GitHub] zhengyangyong opened a new pull request #60: add how to deploy service center in cluster mode

zhengyangyong opened a new pull request #60: add how to deploy service center in cluster mode URL: https://github.com/apache/incubator-servicecomb-website/pull/60 add how to deploy service center in cluster mode This is an au

[GitHub] coveralls commented on issue #647: [SCB-481]Fix qps handler compatible issues due to assumption to schema ids not contains dot

coveralls commented on issue #647: [SCB-481]Fix qps handler compatible issues due to assumption to schema ids not contains dot URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/647#issuecomment-380805380 [![Coverage Status](https://coveralls.io/builds/16496521/bad

[GitHub] little-cui closed pull request #325: SCB-472 Null point reference in zipkin plugin

little-cui closed pull request #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of p

[GitHub] WillemJiang commented on issue #647: [SCB-481]Fix qps handler compatible issues due to assumption to schema ids not contains dot

WillemJiang commented on issue #647: [SCB-481]Fix qps handler compatible issues due to assumption to schema ids not contains dot URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/647#issuecomment-381015747 @liubao68 Please update the commit message with JIRA number on

[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r181286527 ## File path: demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/service

[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r181286536 ## File path: demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/service

[GitHub] Rajadeepan opened a new pull request #648: [SCB-482] Http2 support for java-chassis

Rajadeepan opened a new pull request #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue]

[GitHub] coveralls commented on issue #627: [SCB-292] chassis support standard parameter validation

coveralls commented on issue #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#issuecomment-377222163 [](https://coveralls.io/builds/164