[GitHub] Rajadeepan commented on issue #648: [SCB-482] Http2 support for java-chassis

2018-04-16 Thread GitBox
Rajadeepan commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381851678 UT and IT is in progress will raise the commit soon.

[GitHub] zhfeng commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
zhfeng commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173#issuecomment-381811623 what is the purpose of this test ? I think it would like to show the scenario that when the saga transaction

[GitHub] wujimin commented on issue #648: [SCB-482] Http2 support for java-chassis

2018-04-16 Thread GitBox
wujimin commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381799184 please paste compile warning check image This is an

[GitHub] zhengyangyong commented on a change in pull request #650: add springmvc archetype

2018-04-16 Thread GitBox
zhengyangyong commented on a change in pull request #650: add springmvc archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/650#discussion_r181926287 ## File path: archetypes/business-service-springmvc/pom.xml ## @@ -0,0 +1,111 @@ + + +

[GitHub] zhengyangyong commented on a change in pull request #650: add springmvc archetype

2018-04-16 Thread GitBox
zhengyangyong commented on a change in pull request #650: add springmvc archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/650#discussion_r181925334 ## File path: archetypes/business-service-springmvc/pom.xml ## @@ -0,0 +1,111 @@ + + +

[GitHub] zhengyangyong commented on a change in pull request #650: add springmvc archetype

2018-04-16 Thread GitBox
zhengyangyong commented on a change in pull request #650: add springmvc archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/650#discussion_r181925334 ## File path: archetypes/business-service-springmvc/pom.xml ## @@ -0,0 +1,111 @@ + + +

[GitHub] zhengyangyong commented on a change in pull request #650: add springmvc archetype

2018-04-16 Thread GitBox
zhengyangyong commented on a change in pull request #650: add springmvc archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/650#discussion_r181925100 ## File path:

[GitHub] zhengyangyong commented on a change in pull request #650: add springmvc archetype

2018-04-16 Thread GitBox
zhengyangyong commented on a change in pull request #650: add springmvc archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/650#discussion_r181925474 ## File path:

[GitHub] zhengyangyong commented on a change in pull request #650: add springmvc archetype

2018-04-16 Thread GitBox
zhengyangyong commented on a change in pull request #650: add springmvc archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/650#discussion_r181925334 ## File path: archetypes/business-service-springmvc/pom.xml ## @@ -0,0 +1,111 @@ + + +

[GitHub] zhengyangyong commented on a change in pull request #650: add springmvc archetype

2018-04-16 Thread GitBox
zhengyangyong commented on a change in pull request #650: add springmvc archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/650#discussion_r181925100 ## File path:

[GitHub] wujimin commented on a change in pull request #650: add springmvc archetype

2018-04-16 Thread GitBox
wujimin commented on a change in pull request #650: add springmvc archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/650#discussion_r181923982 ## File path: archetypes/business-service-springmvc/pom.xml ## @@ -0,0 +1,111 @@ + + +

[GitHub] WillemJiang commented on a change in pull request #650: add springmvc archetype

2018-04-16 Thread GitBox
WillemJiang commented on a change in pull request #650: add springmvc archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/650#discussion_r181761713 ## File path: archetypes/business-service-springmvc/src/main/resources/META-INF/spring/provider.bean.xml

[GitHub] WillemJiang commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
WillemJiang commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173#issuecomment-381624030 It looks like the Accept test result is not good. We need to fix the issue here.

[GitHub] WillemJiang commented on a change in pull request #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
WillemJiang commented on a change in pull request #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173#discussion_r181758476 ## File path:

[GitHub] WillemJiang commented on a change in pull request #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
WillemJiang commented on a change in pull request #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173#discussion_r181758208 ## File path:

[GitHub] WillemJiang commented on a change in pull request #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
WillemJiang commented on a change in pull request #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173#discussion_r181757819 ## File path:

[GitHub] WillemJiang commented on a change in pull request #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
WillemJiang commented on a change in pull request #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173#discussion_r181756799 ## File path:

[GitHub] coveralls commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
coveralls commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173#issuecomment-381571490 [![Coverage Status](https://coveralls.io/builds/16537095/badge)](https://coveralls.io/builds/16537095)

[GitHub] dengyingtuo commented on issue #329: 建议新增mac版的release

2018-04-16 Thread GitBox
dengyingtuo commented on issue #329: 建议新增mac版的release URL: https://github.com/apache/incubator-servicecomb-service-center/issues/329#issuecomment-381601054 docker也可以,不过好多人也没有装docker This is an automated message from the

[GitHub] WillemJiang commented on issue #329: 建议新增mac版的release

2018-04-16 Thread GitBox
WillemJiang commented on issue #329: 建议新增mac版的release URL: https://github.com/apache/incubator-servicecomb-service-center/issues/329#issuecomment-381594836 使用docker image也是一个可以解决的办法,后续我们会推出mac版本。 This is an automated message

[GitHub] coveralls commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
coveralls commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173#issuecomment-381571490 [![Coverage Status](https://coveralls.io/builds/16535911/badge)](https://coveralls.io/builds/16535911)

[GitHub] coveralls commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
coveralls commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173#issuecomment-381571490 [![Coverage Status](https://coveralls.io/builds/16535265/badge)](https://coveralls.io/builds/16535265)

[GitHub] coveralls commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
coveralls commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173#issuecomment-381571490 [![Coverage Status](https://coveralls.io/builds/16535272/badge)](https://coveralls.io/builds/16535272)

[GitHub] coveralls commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
coveralls commented on issue #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173#issuecomment-381571490 [![Coverage Status](https://coveralls.io/builds/16535265/badge)](https://coveralls.io/builds/16535265)

[GitHub] lijasonvip opened a new pull request #173: [SCB-300] acceptance test for @Compensable event timeout

2018-04-16 Thread GitBox
lijasonvip opened a new pull request #173: [SCB-300] acceptance test for @Compensable event timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/173 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a

[GitHub] coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis

2018-04-16 Thread GitBox
coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381568126 [![Coverage Status](https://coveralls.io/builds/16535073/badge)](https://coveralls.io/builds/16535073)

[GitHub] dengyingtuo opened a new issue #329: 建议新增mac版的release

2018-04-16 Thread GitBox
dengyingtuo opened a new issue #329: 建议新增mac版的release URL: https://github.com/apache/incubator-servicecomb-service-center/issues/329 我使用mac开发,发现没有对应的release,这给第一次使用的人带来很多不方便,可能很多人会因此放弃尝试 过程:

[GitHub] liubao68 closed pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-16 Thread GitBox
liubao68 closed pull request #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] liubao68 commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-16 Thread GitBox
liubao68 commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r181674104 ## File path:

[GitHub] liubao68 closed pull request #632: [SCB-456]Provider a way to input configuration from a Map

2018-04-16 Thread GitBox
liubao68 closed pull request #632: [SCB-456]Provider a way to input configuration from a Map URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/632 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] coveralls commented on issue #649: [SCB-488]Retry/Metrics some default behavior cause unnecessary retry and logs

2018-04-16 Thread GitBox
coveralls commented on issue #649: [SCB-488]Retry/Metrics some default behavior cause unnecessary retry and logs URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/649#issuecomment-381527384 [![Coverage

[GitHub] zhengyangyong opened a new pull request #650: add springmvc archetype

2018-04-16 Thread GitBox
zhengyangyong opened a new pull request #650: add springmvc archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/650 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and

[GitHub] wujimin commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-16 Thread GitBox
wujimin commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r181639466 ## File path: