[GitHub] keepongjl opened a new issue #659: 是否考虑支持函数重载

2018-04-18 Thread GitBox
keepongjl opened a new issue #659: 是否考虑支持函数重载 URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/659 现在的Provider不支持函数重载(契约生成会报错Caused by: java.lang.Error: OperationId must be unique),是否考虑支持函数重载? This is

[GitHub] yangbor commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

2018-04-18 Thread GitBox
yangbor commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r182619742 ## File path:

[GitHub] weichao666 commented on issue #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-18 Thread GitBox
weichao666 commented on issue #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-382585058 modified This is an

[GitHub] liubao68 commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

2018-04-18 Thread GitBox
liubao68 commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382582463 I am using eclipse and all compile warnings fixed except

[GitHub] liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

2018-04-18 Thread GitBox
liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182612283 ## File path:

[GitHub] liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

2018-04-18 Thread GitBox
liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182611014 ## File path:

[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout

2018-04-18 Thread GitBox
coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621 [![Coverage

[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout

2018-04-18 Thread GitBox
coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621 [![Coverage

[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout

2018-04-18 Thread GitBox
coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621 [![Coverage

[GitHub] WillemJiang commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-18 Thread GitBox
WillemJiang commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182465491 ## File path:

[GitHub] zhfeng opened a new pull request #175: SCB-505 Update to throw exception when the transaction timeout

2018-04-18 Thread GitBox
zhfeng opened a new pull request #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a

[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-18 Thread GitBox
wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182437916 ## File path:

[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-18 Thread GitBox
wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182439425 ## File path:

[GitHub] Rajadeepan commented on issue #648: [SCB-482] Http2 support for java-chassis

2018-04-18 Thread GitBox
Rajadeepan commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-382374604 commit added for UT and IT This is an automated

[GitHub] coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis

2018-04-18 Thread GitBox
coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381568126 [![Coverage Status](https://coveralls.io/builds/16575497/badge)](https://coveralls.io/builds/16575497)

[GitHub] coveralls commented on issue #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-18 Thread GitBox
coveralls commented on issue #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#issuecomment-382350160 [![Coverage

[GitHub] zhengyangyong opened a new pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-18 Thread GitBox
zhengyangyong opened a new pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658 Signed-off-by: zhengyangyong Follow this checklist to help us

[GitHub] coveralls commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

2018-04-18 Thread GitBox
coveralls commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382318550 [![Coverage

[GitHub] wujimin commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

2018-04-18 Thread GitBox
wujimin commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382310371 paste compile warning check image please.

[GitHub] liubao68 opened a new pull request #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

2018-04-18 Thread GitBox
liubao68 opened a new pull request #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657 Follow this checklist to help us incorporate your contribution quickly and

[GitHub] coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download

2018-04-18 Thread GitBox
coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382072555 [![Coverage Status](https://coveralls.io/builds/16572229/badge)](https://coveralls.io/builds/16572229)

[GitHub] wujimin commented on issue #653: [SCB-483] Springmvc rest vertx file download

2018-04-18 Thread GitBox
wujimin commented on issue #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382290341 add a new commit: "set correct content-type for download"