[GitHub] wujimin commented on a change in pull request #670: [SCB-512] download support chinese and space in file name

2018-04-22 Thread GitBox
wujimin commented on a change in pull request #670: [SCB-512] download support chinese and space in file name URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/670#discussion_r183289727 ## File path: demo/demo-springmvc/springmvc-client/src/main/java/org/apach

[GitHub] WillemJiang commented on a change in pull request #670: [SCB-512] download support chinese and space in file name

2018-04-22 Thread GitBox
WillemJiang commented on a change in pull request #670: [SCB-512] download support chinese and space in file name URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/670#discussion_r183285278 ## File path: demo/demo-springmvc/springmvc-client/src/main/java/org/a

[GitHub] wujimin commented on a change in pull request #670: [SCB-512] download support chinese and space in file name

2018-04-22 Thread GitBox
wujimin commented on a change in pull request #670: [SCB-512] download support chinese and space in file name URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/670#discussion_r183289727 ## File path: demo/demo-springmvc/springmvc-client/src/main/java/org/apach

[GitHub] zenlinTechnofreak commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype

2018-04-22 Thread GitBox
zenlinTechnofreak commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r183287128 ## File path: archetypes/business-service-spring-boot-starter/src/mai

[GitHub] asifdxtreme closed pull request #331: SCB-513 Add range delete support in registry command

2018-04-22 Thread GitBox
asifdxtreme closed pull request #331: SCB-513 Add range delete support in registry command URL: https://github.com/apache/incubator-servicecomb-service-center/pull/331 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the s

[GitHub] coveralls commented on issue #671: [SCB-516] fix accessLog traceId printing problem in EdgeService

2018-04-22 Thread GitBox
coveralls commented on issue #671: [SCB-516] fix accessLog traceId printing problem in EdgeService URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/671#issuecomment-383468848 [![Coverage Status](https://coveralls.io/builds/16643775/badge)](https://coveralls.io/bu

[GitHub] WillemJiang commented on a change in pull request #670: [SCB-512] download support chinese and space in file name

2018-04-22 Thread GitBox
WillemJiang commented on a change in pull request #670: [SCB-512] download support chinese and space in file name URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/670#discussion_r183285278 ## File path: demo/demo-springmvc/springmvc-client/src/main/java/org/a

Re: [Discussion]Java Chassis change all configuration from 'cse.xxx' to 'servicecomb.xxx'

2018-04-22 Thread kirin wang
+1 LGTM 2018-04-23 13:34 GMT+08:00 Zen Lin : > +1 nobinding > Twice types of prefix should confuse the users and developers. > I think it should be very nice if someone can findout and remove all the > 'CSE' prefix in the whole project, but not only in the configuration. > > Best Regards, > --- >

[GitHub] yhs0092 opened a new pull request #671: [SCB-516] fix accessLog traceId printing problem in EdgeService

2018-04-22 Thread GitBox
yhs0092 opened a new pull request #671: [SCB-516] fix accessLog traceId printing problem in EdgeService URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/671 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure ther

Re: [Discussion]Java Chassis change all configuration from 'cse.xxx' to 'servicecomb.xxx'

2018-04-22 Thread Zen Lin
+1 nobinding Twice types of prefix should confuse the users and developers. I think it should be very nice if someone can findout and remove all the 'CSE' prefix in the whole project, but not only in the configuration. Best Regards, --- Zen Lin zenlintechnofr...@gmail.com Focused on Micro Service

[GitHub] zhengyangyong opened a new pull request #67: In the "General Development/Use ServiceComb in Spring Boot" document,…

2018-04-22 Thread GitBox
zhengyangyong opened a new pull request #67: In the "General Development/Use ServiceComb in Spring Boot" document,… URL: https://github.com/apache/incubator-servicecomb-website/pull/67 Signed-off-by: zhengyangyong In the "General Development/Use ServiceComb in Spring Boot" document,

[GitHub] coveralls commented on issue #670: [SCB-512] download support chinese and space in file name

2018-04-22 Thread GitBox
coveralls commented on issue #670: [SCB-512] download support chinese and space in file name URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/670#issuecomment-383443330 [![Coverage Status](https://coveralls.io/builds/16642711/badge)](https://coveralls.io/builds/1

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-22 Thread GitBox
yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-383443209 @little-cui Yes I have considered the httputil.ReverseProxy. But it seems too primitive and does not suppo

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-22 Thread GitBox
yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-383442857 @asifdxtreme Yes this implementation works if the frontend and service-center is running in the same docke

[GitHub] coveralls commented on issue #669: [SCB-515] change all config of 'cse.xxx' to 'servicecomb.xxx'

2018-04-22 Thread GitBox
coveralls commented on issue #669: [SCB-515] change all config of 'cse.xxx' to 'servicecomb.xxx' URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/669#issuecomment-383439665 [![Coverage Status](https://coveralls.io/builds/16642526/badge)](https://coveralls.io/buil

[GitHub] wujimin opened a new pull request #670: [SCB-512] download support chinese and space in file name

2018-04-22 Thread GitBox
wujimin opened a new pull request #670: [SCB-512] download support chinese and space in file name URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/670 chinese and space filename in response header should support chrome/firefox/ie ![image](https://user-images.githu

Re: [Discussion]Java Chassis change all configuration from 'cse.xxx' to 'servicecomb.xxx'

2018-04-22 Thread Jean-Baptiste Onofré
+1 Regards JB Le 23 avr. 2018 à 05:49, à 05:49, "郑扬勇" a écrit: >Hi ,all : >we had support both style of configuration for a long time (since >0.2.0): >https://github.com/apache/incubator-servicecomb-java-chassis/pull/91 > But all demos and samples in our code still use 'cse.xxx' such as : > >

[GitHub] WillemJiang closed pull request #66: Add slide for 0421 vivo Spring Cloud community salon

2018-04-22 Thread GitBox
WillemJiang closed pull request #66: Add slide for 0421 vivo Spring Cloud community salon URL: https://github.com/apache/incubator-servicecomb-website/pull/66 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pr

[GitHub] yangbor opened a new pull request #66: Add slide for 0421 vivo Spring Cloud community salon

2018-04-22 Thread GitBox
yangbor opened a new pull request #66: Add slide for 0421 vivo Spring Cloud community salon URL: https://github.com/apache/incubator-servicecomb-website/pull/66 This is an automated message from the Apache Git Service. To re

[GitHub] liubao68 closed pull request #668: [SCB-487] SDK consumer download file

2018-04-22 Thread GitBox
liubao68 closed pull request #668: [SCB-487] SDK consumer download file URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/668 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] zhengyangyong opened a new pull request #669: [SCB-515] change all config of 'cse.xxx' to 'servicecomb.xxx'

2018-04-22 Thread GitBox
zhengyangyong opened a new pull request #669: [SCB-515] change all config of 'cse.xxx' to 'servicecomb.xxx' URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/669 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly

Re: [Discussion]Java Chassis change all configuration from 'cse.xxx' to 'servicecomb.xxx'

2018-04-22 Thread Willem Jiang
+1 for updating the documents and examples. As we support cse, and servicecomb prefix at the same time, the old configuration can still work (maybe we can add some info log to tell the user we are going to update the configuration setting). It's better to use the servicecomb prefix before releasin

[Discussion]Java Chassis change all configuration from 'cse.xxx' to 'servicecomb.xxx'

2018-04-22 Thread ??????
Hi ,all : we had support both style of configuration for a long time (since 0.2.0): https://github.com/apache/incubator-servicecomb-java-chassis/pull/91 But all demos and samples in our code still use 'cse.xxx' such as : APPLICATION_ID: multiple service_description: name: a-server ve

[GitHub] coveralls commented on issue #668: [SCB-487] SDK consumer download file

2018-04-22 Thread GitBox
coveralls commented on issue #668: [SCB-487] SDK consumer download file URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/668#issuecomment-383386023 [![Coverage Status](https://coveralls.io/builds/16638574/badge)](https://coveralls.io/builds/16638574) Covera

[GitHub] coveralls commented on issue #138: SCB-224 retry sub-transaction on failure

2018-04-22 Thread GitBox
coveralls commented on issue #138: SCB-224 retry sub-transaction on failure URL: https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986 [![Coverage Status](https://coveralls.io/builds/16638398/badge)](https://coveralls.io/builds/16638398) Coverage d

[GitHub] wujimin opened a new pull request #668: [SCB-487] SDK consumer download file

2018-04-22 Thread GitBox
wujimin opened a new pull request #668: [SCB-487] SDK consumer download file URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/668 ![image](https://user-images.githubusercontent.com/16874843/39093915-c258ba8c-4659-11e8-859d-da66cf2f6c96.png) ---

[GitHub] liubao68 closed pull request #650: [SCB-442] add springmvc archetype

2018-04-22 Thread GitBox
liubao68 closed pull request #650: [SCB-442] add springmvc archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/650 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] liubao68 closed pull request #667: [SCB-486] Edge route download

2018-04-22 Thread GitBox
liubao68 closed pull request #667: [SCB-486] Edge route download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/667 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this