[GitHub] hank-whu commented on issue #685: 怎样平滑关闭Client?

2018-05-06 Thread GitBox
hank-whu commented on issue #685: 怎样平滑关闭Client? URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/685#issuecomment-386971260 不行的,还是有线程没被正确关闭 ```java Non-finished threads: Thread[transport-vert.x-eventloop-thread-3,5,main] at java.base@9.0

[GitHub] wujimin commented on issue #690: [SCB-529] producer download file from byte[]

2018-05-06 Thread GitBox
wujimin commented on issue #690: [SCB-529] producer download file from byte[] URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/690#issuecomment-386955750 infact, maybe it's not a good practic 1.if byte[] come from file, then return file is better 2.if byte[] come

[GitHub] coveralls commented on issue #692: [SCB-543]optimize registry procedure

2018-05-06 Thread GitBox
coveralls commented on issue #692: [SCB-543]optimize registry procedure URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/692#issuecomment-386952358 [![Coverage Status](https://coveralls.io/builds/16859270/badge)](https://coveralls.io/builds/16859270) Covera

[GitHub] mt-monster opened a new pull request #692: [SCB-543]optimize registry procedure

2018-05-06 Thread GitBox
mt-monster opened a new pull request #692: [SCB-543]optimize registry procedure URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/692 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](http

[GitHub] WillemJiang closed pull request #77: Add Notes for providers and fix FAQ mistakes

2018-05-06 Thread GitBox
WillemJiang closed pull request #77: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/77 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] zhengyangyong commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes

2018-05-06 Thread GitBox
zhengyangyong commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/77#discussion_r186284440 ## File path: _users/cn/develop-with-transparent-rpc.md ## @@ -130,6 +137,10 @@

[GitHub] zhengyangyong commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes

2018-05-06 Thread GitBox
zhengyangyong commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/77#discussion_r186284441 ## File path: _users/develop-with-transparent-rpc.md ## @@ -122,6 +129,10 @@ Th