Re: [VOTE] Move github notifications to maillist "comm...@servicecomb.apache.org"

+1 non binding 2018-05-11 21:12 GMT+08:00 wjm wjm : > +1 > > 2018-05-11 17:52 GMT+08:00 Willem Jiang : > > > +1 , it could make the dev discuss more focused. > > > > > > Willem Jiang > > > > Blog: http://willemjiang.blogspot.com (English) > >

[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown

wujimin commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388522879 and CI failed, it's about trace, i can find what happened, it seems that did not print error test case name?

[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown

wujimin commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388522824 ShutdownHookHandler is not so good, sometimes will block shutdown process cause of wrong statistics, must depend on

[GitHub] wujimin commented on a change in pull request #699: [SCB-532] Support recursive dependency

wujimin commented on a change in pull request #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187761407 ## File path:

[GitHub] WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency

WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187755431 ## File path:

[GitHub] WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency

WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187755264 ## File path:

Re: [VOTE] Move github notifications to maillist "comm...@servicecomb.apache.org"

+1 2018-05-11 17:52 GMT+08:00 Willem Jiang : > +1 , it could make the dev discuss more focused. > > > Willem Jiang > > Blog: http://willemjiang.blogspot.com (English) > http://jnn.iteye.com (Chinese) > Twitter: willemjiang > Weibo: 姜宁willem > > On Fri, May 11,

Re: [VOTE] Move github notifications to maillist "comm...@servicecomb.apache.org"

+1 , it could make the dev discuss more focused. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Fri, May 11, 2018 at 4:51 PM, kirin wang wrote: > Hi Community: > >

Re: [VOTE] Move github notifications to maillist "comm...@servicecomb.apache.org"

+1 (non-binding) On Fri, May 11, 2018 at 4:51 PM, kirin wang wrote: > Hi Community: > > As we already discussed in [1], this is a call for vote to move > github notifications of Apache ServiceComb to maillist " > comm...@servicecomb.apache.org" . > > Voting

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388301667 improve gracefully shutdown process order ```java private void gracefullyShutdown() { //Step 1:

[GitHub] coveralls commented on issue #693: [SCB-548] support gracefully shutdown

coveralls commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387664923 [](https://coveralls.io/builds/16935269)

Re: [Discussion] Move Gitbox Notifications from dev@servicecomb.apache.org to a new maillist

Thank you for all your advices! I will start a VOTE to confirm that . 2018-05-09 19:04 GMT+08:00 Zen Lin : > Hi > > I also gone through the commits mailing list about other project. > It seems consistent with what Jean-Baptiste said, like an "umbrella" > receiving

[GitHub] coveralls commented on issue #699: [SCB-532] Support recursive dependency

coveralls commented on issue #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#issuecomment-388288890 [](https://coveralls.io/builds/16934947)

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388286655 Rebase on latest master This is an automated

[GitHub] coveralls commented on issue #693: [SCB-548] support gracefully shutdown

coveralls commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387664923 [](https://coveralls.io/builds/16934683)

[GitHub] wujimin opened a new pull request #699: [SCB-532] Support recursive dependency

wujimin opened a new pull request #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699 support create recursive dependency class ``` 1. class A { A a; } 2. class A { B b; } class B { A a;

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388278489 I had used a Semaphore in order to sync all invocation had finished.now gracefully shutdown had fixed below order

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388278489 I had used a Semaphore in order to sync all invocation had finished.now gracefully shutdown had fixed below :

[GitHub] little-cui closed pull request #348: SCB-491 Add the Test Schema Feature

little-cui closed pull request #348: SCB-491 Add the Test Schema Feature URL: https://github.com/apache/incubator-servicecomb-service-center/pull/348 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: