?????? [DISCUSS] Swagger parameter default values whilegeneratingtheschema file

2018-07-26 Thread bismy
Well, this is fine and I think we have the same conclusion. We implement this behavior according to mail I send before. > >a. JAX-RS defaults: required=false and defalutValue not specified > >b. Spring MVC default: required=true adefalutValue not specifiednd @mahesh How do you

Re: [DISCUSS] Swagger parameter default values while generatingtheschema file

2018-07-26 Thread wjm wjm
in jaxrs mode, required default to false, if primitive type not annotated by @DefaultValue, should generated defaultValue to swagger in springmvc mode, not support standard jaxrs behavior, so we no need to process it. (if not consider compatible to standard springmvc, i feel that standard jaxrs

Re: [VOTE] Release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0

2018-07-26 Thread wjm wjm
SCB-575 still in OPEN status 2018-07-27 8:55 GMT+08:00 wjm wjm : > SCB-592 also have won't fix problem > > it's better everybody check their own issues >

Re: [VOTE] Release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0

2018-07-26 Thread wjm wjm
SCB-592 also have won't fix problem it's better everybody check their own issues

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0 (RC-03)

2018-07-26 Thread wjm wjm
+1 binding 1. check release notes and binaries. [OK] 2. run test case using windows version. [OK] 2018-07-26 22:32 GMT+08:00 Willem Jiang : > +1 binding > > I checked: > - hashes and signatures looks good > - DISCLAIMER/NOTICE/LICENSE looks good > - can make build the kit from source > -

Re: Spring Session Support in Java Chassis

2018-07-26 Thread wjm wjm
infact, in springboot2 reactive stack, it's also not compatible: - can not use servlet request and response, must switch to new class - can not use selvlet filters all mechanism about servlet we are similar, if customer want to use servlet stack, then use them as before, but if DO

Re: [DISCUSS] Proposal for holding an ServiceComb Meetup in Bangalore, India

2018-07-26 Thread Jean-Baptiste Onofré
+1 It would be great to have at least meeting notes on the mailing list. Regards JB On 26/07/2018 14:43, Willem Jiang wrote: > +1, it's great that we can hold this kind of meet up. > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Wed, Jul 25, 2018 at 9:17 PM, Mohammad

Re: [VOTE] Release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0

2018-07-26 Thread Willem Jiang
+1 binding. I checked: - hashes and signatures are good - DISCLAIMER exists , NOTICE/LICENSE looks good - can build the kit from source - git tag is write - Running the Company example with the stage repo without any error. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Jul 25,

Re: Spring Session Support in Java Chassis

2018-07-26 Thread Willem Jiang
For the normal user, they just want to use the session information as they use in the web container. It could be great if we can still support spring session out of box. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Jul 26, 2018 at 10:03 PM, wjm wjm wrote: > java chassis

Re: Spring Session Support in Java Chassis

2018-07-26 Thread wjm wjm
java chassis invocation context is easier than session but in edge, if we provide a distributed session, that can make manage session easier. 2018-07-26 17:58 GMT+08:00 bismy : > Java Chassis now do not provide a easy session management but do give a > suggestion to manage it at edge service[1].

Re: [DISCUSS] Proposal for holding an ServiceComb Meetup inBangalore, India

2018-07-26 Thread wjm wjm
对英语停用 +1, it's great help to promote ServiceComb 2018-07-26 20:48 GMT+08:00 bismy : > +1, it's great help to promote ServiceComb > > > > > -- 原始邮件 -- > 发件人: "willem.jiang"; > 发送时间: 2018年7月26日(星期四) 晚上8:43 > 收件人: "dev"; > > 主题: Re: [DISCUSS] Proposal for holding

Re: [DISCUSS] Swagger parameter default values while generating theschema file

2018-07-26 Thread wjm wjm
" e. when generating swagger, generate defalutValue only when explicitly specified." add another point: for primitive type, even there is no @DefaultValue annotation, should have it's default value 2018-07-26 19:42 GMT+08:00 bismy : > My suggestions are as follows > 1. Encourage providers to

Re: 【Proposal】Close ServiceComb group on github

2018-07-26 Thread Willem Jiang
FYI, I just transfer those repos into go-chassis group. https://github.com/ServiceComb/go-chassis https://github.com/ServiceComb/cse-collector https://github.com/ServiceComb/go-cc-client https://github.com/ServiceComb/go-archaius https://github.com/ServiceComb/go-sc-client

Re: [DISCUSS] Proposal for holding an ServiceComb Meetup in Bangalore, India

2018-07-26 Thread Willem Jiang
+1, it's great that we can hold this kind of meet up. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Jul 25, 2018 at 9:17 PM, Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > Hi All, > > As a Bangalore is known as a Sillicon Valley of India which is a home for > millions

??????[VOTE] Release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0

2018-07-26 Thread bismy
+1 binding Checks I have done. 1. check the release notes. [OK] 2. check the binaries and sources.[OK] 3. Integrate the candidate to run all integration tests passed. [OK] -- -- ??: "Mohammad Asif Siddiqui"; : 2018??7??25??(??) 5:09

Re: [VOTE] Release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0

2018-07-26 Thread Mahesh Raju Somalaraju
+1 non binding Checks done: - hashes and signatures good - DISCLAIMER/NOTICE/LICENSE exists - Ran UT and IT - ran RAT tool - can make release kit from source - Ran sample demos with using service center. - Source file have ASF headers Regards -Mahesh Raju S On Thu, Jul 26, 2018 at 1:19 PM

Re: [DISCUSS] Swagger parameter default values while generating theschema file

2018-07-26 Thread bismy
My suggestions are as follows 1. Encourage providers to specify required & defalutValue explicitly. a. when required=true and defaultValue is given, if consumers do not give a value, use default value; b. when required=true and defaultValue is not given, if consumers do not give a value,

?????? Spring Session Support in Java Chassis

2018-07-26 Thread bismy
Java Chassis now do not provide a easy session management but do give a suggestion to manage it at edge service[1]. If we need to think about Spring Session, we should think about how to use Session API like HttpSession. But java chassis is not a J2EE implementation. Do we implement a

Re: Spring Session Support in Java Chassis

2018-07-26 Thread Willem Jiang
After went through the code, it looks like the PR[1] was not merged into master branch. [1]https://github.com/vert-x3/vertx-web/pull/950 Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Jul 26, 2018 at 4:35 PM, wjm wjm wrote: > by ClusteredSessionStore, vertx can also do this >

?????? [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0 (RC-03)

2018-07-26 Thread Sure
+1 binding 1. check the UI topology BUG is fixed 2. the use cases ars passed -- -- ??: "Mohammad Asif Siddiqui"; : 2018??7??26??(??) 3:45 ??: "dev"; : Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)

Re: Spring Session Support in Java Chassis

2018-07-26 Thread wjm wjm
by ClusteredSessionStore, vertx can also do this but currently, there is no a official IMPL: https://github.com/vert-x3/vertx-web/issues/890 2018-07-26 15:31 GMT+08:00 Willem Jiang : > Hi team, > > Today I had a quick talk with the custom who is quite interested about take > the session out from

?????? Cannot find the instance in ServiceComb Discovery

2018-07-26 Thread Sure
oh yes, i had new an issue for it Log print more detailed: https://issues.apache.org/jira/browse/SCB-776 -- -- ??: "willem.jiang"; : 2018??7??26??(??) 3:44 ??: "dev"; : Re: Cannot find the instance in ServiceComb

Re: [VOTE] Release Apache ServiceComb Java-Chassis (Incubating) version 1.0.0

2018-07-26 Thread Mohammad Asif Siddiqui
+1 binding Checks I did: - hashes and signatures is good - DISCLAIMER/NOTICE/LICENSE exists - ran RAT tool - can make release kit from source - checked for archive matching git tag - Source file have ASF headers - Ran UT using source Regards Asif On 2018/07/25 09:09:52,

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0 (RC-03)

2018-07-26 Thread Mohammad Asif Siddiqui
+1 binding Checks I did: - hashes and signatures is good - DISCLAIMER/NOTICE/LICENSE exists - ran RAT tool - can make release kit from source - checked for archive matching git tag - Source file have ASF headers - Ran the java-chassis and go-chassis demo's. - Ran Integration

Re: Cannot find the instance in ServiceComb Discovery

2018-07-26 Thread Willem Jiang
Oh, it's my bad change the saga discovery servicecenter to development mode. Thx Sure for your help. >From the log, I cannot tell it's the development issue, can we polish the logger file to make it easy for user to dig the issue? Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Jul

?????? Cannot find the instance in ServiceComb Discovery

2018-07-26 Thread Sure
sorry, not the car service env mismatch, it is saga-service env mismatch -- -- ??: "Sure"; : 2018??7??26??(??) 3:37 ??: "dev@servicecomb.apache.org"; : ?? Cannot find the instance in ServiceComb Discovery this is

?????? Cannot find the instance in ServiceComb Discovery

2018-07-26 Thread Sure
this is the environment isolation problem. i have check the ci log and found that the car-rental-service is registered in development environment but other services are registered in ''(default) environment. so it will fail when car service discovery hotal service instances from SC.

Spring Session Support in Java Chassis

2018-07-26 Thread Willem Jiang
Hi team, Today I had a quick talk with the custom who is quite interested about take the session out from the single server to the redis cluster with the help of Spring session. In this way they can build the stateless services without changing any application code. I just checked the Spring

[DISCUSS] Swagger parameter default values while generating the schema file

2018-07-26 Thread mahesh somalaraju
Hi All, Currently we are handling the issue related to swagger parameter default values while generating the swagger content. Default value annotation(@DefaultValue) we can provide for PathParam, QueryParam, MatrixParam, CookieParam, FormParam and HeaderParam. The query is when to consider