If the user defines the parameter OmegaContext in the method we pass,
otherwise ignore...
Best regards,
Lei Zhang
On November 14, 2019 at 11:56:49 AM, Zheng Feng (zh.f...@gmail.com) wrote:
In the other word, if the user pass the OmegaContext which is NOT null, we
DO NOT inject the instance curr
In the other word, if the user pass the OmegaContext which is NOT null, we
DO NOT inject the instance currently ? or just ignore it ?
How about if passing the new OmegaContext ?
service.booking(new OmegaContext());
it could be a little bit confusing here.
Willem Jiang 于2019年11月14日周四 上午11:14写道：
This method is called by servlet implementation, so the user won't
call that method.
I think we can support to let the user pass OmegaContext as null
object when calling the method.
And we can inject the runtime OmegaContext instance to as a parameter
when the parameter is null.
Willem Jiang
Twi
OK, I get it. So the HttpServletRequest request has been injected
automatically just when we declare it in the method signatures.
Is there any difference between this declaration and the @Autowired ?
Do we need to guarantee that this is thread-safe ?
anyway, these should be documented very well an
We can refer to the method annotation of spring MVC. The parameter
HttpServletRequest is optional
@RequestMapping()
public void do(HttpServletRequest request){
}
Best regards,
Lei Zhang
On November 14, 2019 at 10:06:57 AM, Zheng Feng (zh.f...@gmail.com) wrote:
But how can we reference
But how can we reference this parameter in the method ? I don't think the
Java support this kind of syntax.
Willem Jiang 于2019年11月14日周四 上午9:43写道：
> Can I invoke the booking method like this ?
> booking().
>
> Then, the OmegaContext would be inject as a parameter?
>
> Willem Jiang
>
> Twitter: wi
Can I invoke the booking method like this ?
booking().
Then, the OmegaContext would be inject as a parameter?
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Thu, Nov 14, 2019 at 9:34 AM Zheng Feng wrote:
>
> So it could introduce an annotation or use the @Resource just like
> @SagaStart
So it could introduce an annotation or use the @Resource just like
@SagaStart
public void booking(@Resource OmegaContext context) {
...
}
and we also can inject the OmegaContext during invoking the method.
Zhang Lei 于2019年11月13日周三 下午11:42写道：
> Hi, Zheng Feng
>
> Both are ok.
>
> I saw in [1] th
Hi, Zheng Feng
Both are ok.
I saw in [1] that the TransactionContext is passed using parameters. I just
recommend passing some parameters in a consistent way.
[1]
https://issues.apache.org/jira/browse/SCB-785?focusedCommentId=16561332&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acommen
+1 and feel free to raise the PR.
郑志鹏 于2019年11月12日周二 上午11:16写道：
> Hi, All
>
> I have created e-commerce project as a ServiceComb sample project for user
> guiding purpose with two other passionate guys. It's not perfect but it's
> working. I want merge it into servicecomb-samples first, so there
I'm not very clear what could be benefited from these changes ? with
declaring the OmegaContext explicitly ?
Willem Jiang 于2019年11月13日周三 下午3:47写道：
> If it is optional, we need to inject the OmegaContext dynamically and
> provide a wrap method for it.
>
> Willem Jiang
>
> Twitter: willemjiang
> W
11 matches
Mail list logo
