Re: Simplify user usage if the OmegaContext parameter is defined in the @SagaStart or @Compensable annotation method

2019-11-14 Thread Willem Jiang
+1. @Zhanglei do you mind create a JIRA for it? Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Nov 14, 2019 at 12:39 PM Zhang Lei wrote: > > If the user defines the parameter OmegaContext in the method we pass, > otherwise ignore... > > > Best regards, > Lei Zhang > > On November 14

[ANN] ServiceComb Toolkit integrates with SonarCloud.io

2019-11-14 Thread Daniel Qian
Hi Toolkit team and all, I've finished the ServiceComb Toolkit project's SonarCloud.io integration work[1]. The SonarCloud project page could be found here[2]. SonarQube is a very useful static code analysis tools, it can find potential bugs and provide code quality reports. I start this thread

Re: [DISCUSSION][Samples] E-commerce sample project want to merge into servicecomb-samples

2019-11-14 Thread Willem Jiang
Please submit your PR step by step, you can submit several PRs with small change set (less than 1000 lines of change). No one can review a big PR once. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Nov 15, 2019 at 3:13 PM 郑志鹏 wrote: > > Hi, > Yes, That's application I mean, but t

Re: [DISCUSSION][Samples] E-commerce sample project want to merge into servicecomb-samples

2019-11-14 Thread 郑志鹏
Hi, Yes, That's application I mean, but the already existed houserush directory in master branch is just a framework without any code. There is also a houserush-sample branch which have some early stage code in it. We already developed a full functional application with 2 passionate guys. And

Re: [Pack] Use Netty native transport improve performance

2019-11-14 Thread Zhang Lei
Great, I will create a JIRA and send the PR Best regards, Lei Zhang On November 15, 2019 at 2:55:20 PM, Willem Jiang (willem.ji...@gmail.com) wrote: checked the license, we are good to go :) Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Nov 15, 2019 at 2:07 PM Zheng Feng wrote:

Re: [DISCUSSION][Samples] E-commerce sample project want to merge into servicecomb-samples

2019-11-14 Thread Willem Jiang
Is there any update of your project. I just realized there is a houserush application[1] in the servicecomb-samples. Do you mean the same project here? [1]https://github.com/apache/servicecomb-samples/tree/master/houserush Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Nov 12, 2019

Re: [Pack] Use Netty native transport improve performance

2019-11-14 Thread Willem Jiang
checked the license, we are good to go :) Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Nov 15, 2019 at 2:07 PM Zheng Feng wrote: > > Thanks a lot for sharing these information and it looks like a great > improvement. > > @Willem Jiang can we release the native libraries in the zip

Re: [Pack] Use Netty native transport improve performance

2019-11-14 Thread Willem Jiang
I just check the document, the steps these ZhangLei lists are installing the development environment for building the native support code. I just checked the code of epoll[1], those files are using Apache License, so we are good to bind these artifacts into our release kit. [1]https://github.com/n

Re: [Pack] Use Netty native transport improve performance

2019-11-14 Thread Willem Jiang
The ssl.properties should be configurable from user perspective. I don't think put those files into the resources to release is best practices. Please go ahead remove it by adding the issue link of netty. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Nov 14, 2019 at 9:50 PM Zhang Lei

Re: [Pack] Use Netty native transport improve performance

2019-11-14 Thread Zheng Feng
Thanks a lot for sharing these information and it looks like a great improvement. @Willem Jiang can we release the native libraries in the zip files ? Zhang Lei 于2019年11月15日周五 下午12:50写道: > Optimize Alpha Performance Using Netty native transport and up to 40 > percent for QPS > > Simulate sendi

[DISCUSSION][Toolkit] Oas validator style check rule config file format

2019-11-14 Thread Daniel Qian
Hi toolkit team, I'm working on SCB-1580[1] to make OAS style check configurable. So we need a config file which can describe the check rules. I created a config file example on gist[2], which is based on the oas validator style check doc[3] Any suggestions are welcome. [1] https://issues.apache.o

Re: [Pack] Use Netty native transport improve performance

2019-11-14 Thread Zhang Lei
Optimize Alpha Performance Using Netty native transport and up to 40 percent for QPS Simulate sending 50,000 global transactions (one global transaction contains 3 sub-transactions), The latest Alpha single node and single client benchmark report is as follows: # Report 1 Warm Up

Re: [Pack] Use Netty native transport improve performance

2019-11-14 Thread Zhang Lei
I Just add two dependencies netty-transport-native-kqueue and netty-transport-native-epoll. Although these dependencies contain libnetty_transport_native_epoll_x86_64.so and libnetty_transport_native_kqueue_x86_64.jnilib files but they use Apache License 2.0 Other than release does not contain any

Re: [Pack] Use Netty native transport improve performance

2019-11-14 Thread Zheng Feng
It looks good to and can you confirm which license these native libraries are using ? especially they are not the part of the netty core. Thanks, Zheng Feng Zhang Lei 于2019年11月14日周四 下午9:50写道: > Hi, Pack Team > > Netty provides native socket transport[1] for Linux and macOS, In order to > suppor

[Pack] Use Netty native transport improve performance

2019-11-14 Thread Zhang Lei
Hi, Pack Team Netty provides native socket transport[1] for Linux and macOS, In order to support it, I need to upgrade Netty to the new version. But there are some problems[2] with the SSL test case after the upgrade. Boringssl does not support cipher ECDHE-ECDSA-AES128-SHA256, You can see it in