Re: [DISCUSS] Limit the memory consumption of ServiceComb-Java-Chassis integration tests

2019-04-13 Thread wjm wjm
seems not important because the limitation is just for IT, not a common mechanism yhs0092 于2019年4月13日周六 下午7:29写道: > Hi, in my new PR[1], the max heap size can be overridden by system > property. Please review it. > > > [1]: https://github.com/apache/servicecomb-java-chassis/pull/1179 > > > Yours

Re: [DISCUSS] Limit the memory consumption of ServiceComb-Java-Chassis integration tests

2019-04-13 Thread yhs0092
Hi, in my new PR[1], the max heap size can be overridden by system property. Please review it. [1]: https://github.com/apache/servicecomb-java-chassis/pull/1179 Yours sincerely Yao Haishi yhs0...@163.com On 4/13/2019 09:14,Willem Jiang wrote: Hi, I just saw the patch, it's better we put

Re: [DISCUSS] Limit the memory consumption of ServiceComb-Java-Chassis integration tests

2019-04-12 Thread Willem Jiang
Hi, I just saw the patch, it's better we put the setting in one place which could be overridden by using the system property. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Apr 12, 2019 at 11:09 AM yhs0092 wrote: > > Hi, currently our integration tests will run serveral microservi

Re: [DISCUSS] Limit the memory consumption of ServiceComb-Java-Chassis integration tests

2019-04-12 Thread wjm wjm
+1 yhs0092 于2019年4月12日周五 上午11:09写道: > Hi, currently our integration tests will run serveral microservice > instances without limiting their memory consumption. As a result, I have to > spare quite a large part of memory to ensure the execution of `mvn clean > install -Pit` does not fail. > Maybe

[DISCUSS] Limit the memory consumption of ServiceComb-Java-Chassis integration tests

2019-04-11 Thread yhs0092
Hi, currently our integration tests will run serveral microservice instances without limiting their memory consumption. As a result, I have to spare quite a large part of memory to ensure the execution of `mvn clean install -Pit` does not fail. Maybe we can set `-Xmx128m` to limit the heap size.