Ok, I’ll keep the old aspect processor way.
And OmegaContextAware annotation have not used in pack, I think we should
delete this unused code.
> On Jan 17, 2019, at 9:54 PM, Willem Jiang wrote:
>
> I prefer to keep the Aspect annotation processor in the old way and OK
> for for put Omega compo
I prefer to keep the Aspect annotation processor in the old way and OK
for for put Omega components initial code together.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Thu, Jan 17, 2019 at 5:36 PM zhaojun wrote:
>
> I’ll try to refactor the code in my local repo today.
> Please feel fre
I’ll try to refactor the code in my local repo today.
Please feel free if you have any advice.
--
Zhao Jun
Apache Sharding-Sphere & ServiceComb
> On Jan 15, 2019, at 11:37 AM, zhaojun wrote:
>
> Hi, Willem
>
> Thanks for the comment.
>
> 1. Current implement we use @EnableAsp
Hi, Willem
Thanks for the comment.
1. Current implement we use @EnableAspectJAutoProxy to create proxy bean,
please see TransactionAspectConfig.
it will auto-config AnontaionAwareAspectJAutoProxyCreator, this is the
AspectJ implementation for AbstractAutoProxyCreator.
If we exetend Abst
Here are some of my comments for the design:
1. I don't think we need to use the internal AOP API
(AbstractAutoProxyCreator), current AOP solution is much
straightforward, we don't need to bind to the internal API unless we
want to create the proxy ourselves.
2. In ServiceComb starter, we have the
I have made omega design for this issue[1], please feel free to give me some
advice.
[1]
https://cwiki.apache.org/confluence/display/SERVICECOMB/refactor+design+of+service-comb+pack+omega
--
Zhao Jun
Apache Sharding-Sphere & ServiceComb
> On Jan 14, 2019, at 5:27 PM, zhaojun
I have created SCB-1113[1] to track this issue.
[1] https://issues.apache.org/jira/browse/SCB-1113
--
Zhao Jun
Apache Sharding-Sphere & ServiceComb
> On Jan 14, 2019, at 5:21 PM, zhaojun wrote:
>
> OK, let me create a JIRA, and try to refactor it
>
> --
> Zhao
OK, let me create a JIRA, and try to refactor it
--
Zhao Jun
Apache Sharding-Sphere & ServiceComb
> On Jan 14, 2019, at 4:50 PM, Willem Jiang wrote:
>
> Yeah, we just need to think about starting the Omega context by wiring
> the components through Spring API, then wrap it with
Yeah, we just need to think about starting the Omega context by wiring
the components through Spring API, then wrap it with Spring Boot
Starter API.
In this way we could support to inject the Omega context not only to
the Spring Boot Application but also Spring Application.
Willem Jiang
Twitter:
That’s a good idea, we can add other methods in the omega and alpha api.
Omega/Alpha was our client/server architecture, so I think omega is enough for
us.
> On Jan 14, 2019, at 3:18 PM, Zheng Feng wrote:
>
> That is a good idea and I think this should be called the client API ?
>
> OmegaClie
That is a good idea and I think this should be called the client API ?
OmegaClient.init();
OmegaClient.beginSaga();
OmegaCleint.endSaga();
...
zhaojun 于2019年1月14日周一 下午3:09写道：
> Hi, all
>
> I think we should provide api way to bootstrap omega and alpha.
> Now our code was tightly coupled with sp
Hi, all
I think we should provide api way to bootstrap omega and alpha.
Now our code was tightly coupled with spring-boot, it is not possible for
integrated with other middleware.
We should provide Omega.init(), Alpha.init() api, spring-boot was just one
implementation for Pack.
Any thought?
-
12 matches
Mail list logo
