yangbor commented on a change in pull request #648: [SCB-482] Http2 support for
java-chassis
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r182619742
##########
File path:
transports/transport-rest/transport-rest-vertx/src/test/java/org/apache/servicecomb/transport/rest/vertx/TestRestServerVerticle.java
##########
@@ -109,6 +109,38 @@ public void testRestServerVerticleWithRouterSSL(@Mocked
Transport transport, @Mo
server.start(startFuture);
}
+ @Test
+ public void testRestServerVerticleWithHttp2(@Mocked Transport transport,
@Mocked Vertx vertx,
+ @Mocked Context context,
+ @Mocked JsonObject jsonObject, @Mocked Future<Void> startFuture) throws
Exception {
+ URIEndpointObject endpointObject = new
URIEndpointObject("http://127.0.0.1:8080?protocol=h2";);
+ new Expectations() {
+ {
+ transport.parseAddress("http://127.0.0.1:8080?protocol=h2";);
Review comment:
ALPN(h2) cannot be used for http schema, only https is allowed to use h2
protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
