Re:[DISCUSS] Optimization for Sharing Parser with Antlr Visitor

2020-02-12 Thread Juan Pan
Hi everyone, Good news for us that we basically finish the parser refactoring for MySQL.[1] Specially thanks for @terrymanu @SteNicholas @dongzl @tianbin1001 @beijing-penguin! Our next step is to do some improvements for new MySQL parser, and continue working on parser refactoring for other

[DISCUSS] Remove some class members from `WhereSegment`

2020-02-12 Thread Juan Pan
Hi everyone, I found the class member `parametersCount` and `parameterMarkerStartIndex` of `WhereSegment .java` are written, but do not used or read by any other objects. So i plan to remove them to simply our parsing module and integrated tests. If i miss something, please tell me ASAP.

Re: [DISCUSS] merge docs and example repos into trunk repo

2020-02-12 Thread Juan Pan
Hi community, ISSUE [1] concerning doc merging has fixed already. Once redundant branch of sharding-sphere-doc is deleted, there will be a successful end. [1] https://github.com/apache/incubator-shardingsphere/issues/4243 Juan Pan (Trista) Senior DBA & PPMC of