Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-21 Thread Willem Jiang
Thanks for the information. I will post my +1 on IPMC mailing list. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Aug 21, 2019 at 1:08 PM Zhang Yonglun wrote: > > Hi, > > Thanks for Willem and Sheng's reminder. I have put the wrong link of Maven > 2 staging repository. > > The link

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Zhang Yonglun
Hi, Thanks for Willem and Sheng's reminder. I have put the wrong link of Maven 2 staging repository. The link is updated to: Maven 2 staging repository: https://repository.apache.org/content/repositories/orgapacheshardingsphere-1022/org/apache/shardingsphere/ We have updated the release

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Zhang Yonglun
Hi Craig, We have updated the release doc[1] to fix the two problems you mentioned so that we can use correct mail template the next time. 1. Use PPMC member instead of binding while community instead of non-binding in the vote result announcement. 2. Add note to invite all mentors to vote

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Sheng Wu
One question Why does not your staging repo include number? > Maven 2 staging repository: > https://repository.apache.org/content/repositories/staging/org/apache/shardingsphere/ There should be a link related to each release process. Please check, if so, I think you just missed deleting old

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Willem Jiang
Sorry, I was traveling last two days and just missed the vote. I just had a quick check of the release kit, most of them are OK but for the staging repo[1] I found there is a RC1 version beside RC2, which means if we do the release in Maven repo, we will publish the RC1 and RC2 version at the same

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Craig Russell
Hi, I'd like to suggest that when a release vote does not get all mentors to vote, we should ping them so the IPMC vote is just a formality. This results in a lot less stress on everyone in the incubator community. If mentors respond that they are just too busy right now, we should accept that

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Craig Russell
Hi, We should not use "binding" as a term when referring to votes of PPMC members. Binding has a specific meaning in Apache that for release votes means IPMC. Better to use "6 PPMC member +1 votes" and "1 community +1 vote". You can refer to "mentor" votes as "binding" but it's better just to

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Zhang Yonglun
The vote to release Apache ShardingSphere (Incubating) 4.0.0-RC2 has passed. 6 binding +1 votes: Liang Zhang Juan Pan Craig L Russell (mentor) Yi Yang Hao Cao Von Gosling (mentor) 1 non-binding +1 vote: Haisheng Sun Gosling Von 于2019年8月20日周二 上午11:28写道: > > Thanks for your prompt reply. > >

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-19 Thread Gosling Von
Thanks for your prompt reply. +1 (mentor) Best Regards, Von Gosling > On Aug 20, 2019, at 11:20 AM, Zhang Yonglun wrote: > > Hi, > > The release files you mentioned are from the NOTICE file of the Netty > project. > > Gosling Von 于2019年8月19日周一 下午5:44写道: > >> Hi, >> >> According to the

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-19 Thread Zhang Yonglun
Hi, The release files you mentioned are from the NOTICE file of the Netty project. Gosling Von 于2019年8月19日周一 下午5:44写道: > Hi, > > According to the checklist, everything looks very good. I focused on the > notice file, one question was raised about some of its statements. You > could look at >

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-19 Thread Gosling Von
Hi, According to the checklist, everything looks very good. I focused on the notice file, one question was raised about some of its statements. You could look at apache-shardingsphere-incubating-4.0.0-RC2-sharding-proxy-bin. I did not find we packaged release files including such as Apache

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-19 Thread Hao Cao
+1 The following checking items have been done. [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-18 Thread sunbufu
+1 The following checking items have been done. [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-18 Thread Sion Yang
+1 The following checking items have been done. [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-18 Thread Craig Russell
+1 (mentor) The following checking items have been done. [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-18 Thread juan pan
+1 The following checking items have been done. [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-17 Thread zhangli...@apache.org
+1 I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license

[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-17 Thread Zhang Yonglun
Hello ShardingSphere Community, This is a call for vote to release Apache ShardingSphere (Incubating) version 4.0.0-RC2 Release notes: https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md The release candidates: