Re: SHIDNIG-805 Revive ConfigContributors and also inject javascript config for container js (issue1625042)

2010-06-10 Thread lindner
This is a bit intrusive, so I hope someone can take a look at this patch. Something that's bothering me is there are cases where the gadgets.config key doesn't match the feature name and also doesn't match the javascript namespace. Ideally they would all be the same to eliminate confusion. In t

Re: Tab is not pre-selected correctly (issue1639042)

2010-06-10 Thread zhoresh
LGTM, Basically support user perf parameter of selectedTab. If previously selected tab is known, use that for selected tab. I committed it as r953463 http://codereview.appspot.com/1639042/show

Re: Cleanning up Shindig for json.org license issue

2010-06-10 Thread Paul Lindner
The plan looks good. Can you refer us to the discussions on the Wink list about this json library? Is the source committed anywhere yet? Will this library be independent of wink or bundled with other software? On Jun 9, 2010, at 8:11 AM, Han Nguyen wrote: > In response to this email thread

Re: [VOTE] Approve Henry Saputra as Shindig Committer

2010-06-10 Thread John Hjelmstad
+1 On Thu, Jun 10, 2010 at 10:05 PM, Chirag Shah wrote: > +1! > > 2010/6/10 ๏̯͡๏ Jasvir Nagra > > > +1 > > > > On Thu, Jun 10, 2010 at 12:28 AM, Jacky Wang (王超) > >wrote: > > > > > +1 :) > > > > > > On Thu, Jun 10, 2010 at 5:15 AM, chico charlesworth < > > > chico.charleswo...@gmail.com> wrote

Re: Cleanning up Shindig for json.org license issue

2010-06-10 Thread John Hjelmstad
Hi Han: This plan sounds good to me; thanks for taking the lead on it. I'm happy to review the trunk/ changes. I'm sure others will be as well. --j On Wed, Jun 9, 2010 at 7:11 PM, Han Nguyen wrote: > In response to this email thread regarding json.org license issue here > > > http://mail-archi

Re: [VOTE] Approve Henry Saputra as Shindig Committer

2010-06-10 Thread Chirag Shah
+1! 2010/6/10 ๏̯͡๏ Jasvir Nagra > +1 > > On Thu, Jun 10, 2010 at 12:28 AM, Jacky Wang (王超) >wrote: > > > +1 :) > > > > On Thu, Jun 10, 2010 at 5:15 AM, chico charlesworth < > > chico.charleswo...@gmail.com> wrote: > > > > > +1 > > > > > > On 9 June 2010 21:49, Ziv Horesh wrote: > > > > > > > t

Re: SHIDNIG-805 Revive ConfigContributors and also inject javascript config for container js (issue1625042)

2010-06-10 Thread lindner
http://codereview.appspot.com/1625042/show

Re: [VOTE] Approve Henry Saputra as Shindig Committer

2010-06-10 Thread ๏̯͡๏ Jasvir Nagra
+1 On Thu, Jun 10, 2010 at 12:28 AM, Jacky Wang (王超) wrote: > +1 :) > > On Thu, Jun 10, 2010 at 5:15 AM, chico charlesworth < > chico.charleswo...@gmail.com> wrote: > > > +1 > > > > On 9 June 2010 21:49, Ziv Horesh wrote: > > > > > true, my bad copy and paste... > > > > > > On Wed, Jun 9, 2010 a

Re: Fix for shindig bug 1346- do not cache 304 responses from origin server (issue1605041)

2010-06-10 Thread John Hjelmstad
(patch committed as r953355, thanks!) On Thu, Jun 10, 2010 at 7:30 PM, John Hjelmstad wrote: > Sounds good re: committing this. > > Re: the remainder, I believe I agree but if I'm not mistaken the underlying > issue is whether we want to support being a "full" HTTP client in the > ETags/If-Modif

Re: Fix for shindig bug 1346- do not cache 304 responses from origin server (issue1605041)

2010-06-10 Thread John Hjelmstad
Sounds good re: committing this. Re: the remainder, I believe I agree but if I'm not mistaken the underlying issue is whether we want to support being a "full" HTTP client in the ETags/If-Modified-Since/etc sense. The issue that gave rise to this behavior is that an HttpFetcher was modified to inc

Re: locked-domain infrastructure configuration

2010-06-10 Thread Paul Lindner
You can use wildcard DNS to support locked domains. A J2EE container should be able to support the differing domains without any problem, unless it's using some server-specific hostname handling, in which case you will need to have a similar wildca

New email address for code reviews

2010-06-10 Thread Paul Lindner
Please use dev-remai...@shindig.apache.org for your code reviews. This will forward it to the full dev list and get around Appspot's issue with using a custom Return-Path header for each message it sends.

locked-domain infrastructure configuration

2010-06-10 Thread David Boyer
We need support for locked-domain. As far as I can tell the only site currently supporting locked-domain is iGoogle. Generating unique domain names by hashing is easy. But how do I get DNS to direct those fake domains back to the right IP address? Also, is there any special configuration of the

Change the default rpc endpoint (issue1613043)

2010-06-10 Thread lindner
Reviewers: dev-remailer_shindig.apache.org, Please review this at http://codereview.appspot.com/1613043/show Affected files: M config/container.js M java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java java/server/src/test/resources/endtoend/errorTest.xml

Re: External libraries in JS features - should they be served though the proxy, or output verbatim?

2010-06-10 Thread Mat Mannion
Ugh, never mind. This can safely be ignored - having looked at the code it is pretty obvious that all you have to do is add inline="true" to the

External libraries in JS features - should they be served though the proxy, or output verbatim?

2010-06-10 Thread Mat Mannion
Hi all, I've been trying to track down some issues we've been having with mixed content warnings. Our gadget container serves content over HTTPS, so when any content is loaded over HTTP, it will (depending on your browser) either show a warning icon (Chrome, Firefox et al) or display an extremely

Re: [VOTE] Approve Henry Saputra as Shindig Committer

2010-06-10 Thread 王超
+1 :) On Thu, Jun 10, 2010 at 5:15 AM, chico charlesworth < chico.charleswo...@gmail.com> wrote: > +1 > > On 9 June 2010 21:49, Ziv Horesh wrote: > > > true, my bad copy and paste... > > > > On Wed, Jun 9, 2010 at 12:49 PM, Paul Lindner wrote: > > > > > Actually your vote is binding (you're on