Re: Refactoring servlets to allow caching response (issue1770043)

2010-07-14 Thread vikaas . arora
http://codereview.appspot.com/1770043/diff/13001/14001 File main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java (left): http://codereview.appspot.com/1770043/diff/13001/14001#oldcode211 main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:211: throws IOException { This

Re: Refactoring servlets to allow caching response (issue1770043)

2010-07-14 Thread vikaas . arora
http://codereview.appspot.com/1770043/diff/13001/14005 File main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java (left): http://codereview.appspot.com/1770043/diff/13001/14005#oldcode89 main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java:89: } Shouldn't you retain this

Re: Handling post requests for Accel servlet (issue1822041)

2010-07-14 Thread gagan . goku
setting follow redirect to false for accel http://codereview.appspot.com/1822041/show

Re: Refactoring servlets to allow caching response (issue1770043)

2010-07-14 Thread gagan . goku
addressing comments http://codereview.appspot.com/1770043/show

Re: Refactoring servlets to allow caching response (issue1770043)

2010-07-14 Thread gagan . goku
http://codereview.appspot.com/1770043/diff/13001/14001 File main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java (left): http://codereview.appspot.com/1770043/diff/13001/14001#oldcode211 main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:211: throws IOException { On

Re: Adding database to Java Shindig

2010-07-14 Thread Evgeny Bogdanov
Well, here is a first post how to use mysql database with java shindig. http://vohtaski.blogspot.com/2010/07/java-shindig-how-to-add-your-own-social.html Next post will be about connecting my own social database with shindig, that I am doing now :) If you find it useful, I can create a wiki

Re: Adding database to Java Shindig

2010-07-14 Thread Henry Saputra
I think you can update the link in the Shindig wiki topic about rel database integration at https://cwiki.apache.org/SHINDIG/index.html#Index-HowdoIintegratearelationaldatabasewithShindig%253F It already has a comment about being need for an update.

Re: Refactoring servlets to allow caching response (issue1770043)

2010-07-14 Thread gagan . goku
fixing bad things http://codereview.appspot.com/1770043/show

Re: Cleaning up HtmlAccelServlet (issue1798042)

2010-07-14 Thread gagan . goku
addressing comments http://codereview.appspot.com/1798042/show

Re: Cleaning up HtmlAccelServlet (issue1798042)

2010-07-14 Thread gagan . goku
http://codereview.appspot.com/1798042/diff/7001/7 File main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java (left): http://codereview.appspot.com/1798042/diff/7001/7#oldcode72 main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java:72: } On 2010/07/14 04:51:10,

Questions about how to implement Upload Content spec

2010-07-14 Thread Gabriel Guardincerri
Hi, I'm implementing Content Uploadhttp://opensocial-resources.googlecode.com/svn/spec/1.0/Core-API-Server.xml#Content-Uploadspec and I have a few question to be sure that I'm understanding it correctly: I wrote an extend exaplantion in a post with title Uploading and storing files data, but it

Re: Handling post requests for Accel servlet (issue1822041)

2010-07-14 Thread johnfargo
Somehow the patch got out of sync w/ the current Shindig (chunk mismatch) -- give it a quick update. Thx http://codereview.appspot.com/1822041/diff/33001/34001 File main/java/org/apache/shindig/gadgets/http/HttpRequest.java (right):

Re: Returning same status code as fetched (issue1811042)

2010-07-14 Thread johnfargo
http://codereview.appspot.com/1811042/diff/23001/24002 File main/java/org/apache/shindig/gadgets/uri/UriUtils.java (left): http://codereview.appspot.com/1811042/diff/23001/24002#oldcode129 main/java/org/apache/shindig/gadgets/uri/UriUtils.java:129: resp.sendError(HttpResponse.SC_BAD_GATEWAY);

Re: Enabling StyleTagProxyEmbeddedUrlsRewriter for accel (issue1813041)

2010-07-14 Thread johnfargo
LGTM, committed. On 2010/07/12 11:05:02, gagan.goku wrote: http://codereview.appspot.com/1813041/show

Re: Enabling StyleTagProxyEmbeddedUrlsRewriter for accel (issue1813041)

2010-07-14 Thread gagan . goku
On 2010/07/14 20:48:57, johnfargo wrote: LGTM, committed. On 2010/07/12 11:05:02, gagan.goku wrote: Thanks http://codereview.appspot.com/1813041/show

Re: json vs json-simple

2010-07-14 Thread Paul Lindner
I spun off 2.0-rc1 a while back, however it's not stable. I'm catching up and will work to get an RC2 release this week and then a final 2.0.0 release in the next two weeks. 2010/7/10 Pablo GraƱa pablo.gr...@globant.com Hi All. We are starting working on integrating shindig in our own

Re: json vs json-simple

2010-07-14 Thread Paul Lindner
Oh and 2.0.0 won't need json-simple, since it's not a direct dependency. There's also been some talk of replacing the json.org code with something similar. Perhaps the people working on that can give a status update on that... On Wed, Jul 14, 2010 at 4:44 PM, Paul Lindner plind...@linkedin.com

Re: Returning same status code as fetched (issue1811042)

2010-07-14 Thread gagan . goku
reverting ProxyingContentRewriter http://codereview.appspot.com/1811042/show