Re: Handling post requests for Accel servlet (issue1822041)

2010-07-15 Thread gagan . goku
http://codereview.appspot.com/1822041/diff/33001/34001 File main/java/org/apache/shindig/gadgets/http/HttpRequest.java (right): http://codereview.appspot.com/1822041/diff/33001/34001#newcode54 main/java/org/apache/shindig/gadgets/http/HttpRequest.java:54: // TODO: Convert to MapString,

Re: Handling post requests for Accel servlet (issue1822041)

2010-07-15 Thread gagan . goku
addressing comments http://codereview.appspot.com/1822041/show

Remove unneeded @imports handling (issue1852041)

2010-07-15 Thread jasvir
Reviewers: gagan.goku, johnfargo, Description: * uses full caja parser rather than a lexer workaround for @imports in CSS * Adds missing broken test for @import url Please review this at http://codereview.appspot.com/1852041/show Affected files: D

Re: Adding database to Java Shindig

2010-07-15 Thread Evgeny Bogdanov
I moved service implementation and database related stuff into Database Shindig Added tutorial on connecting database to shindig Next will add a tutorial on making shindig work with any database schema. Should I remove the deprecated: How do I integrate a relational database with

Re: Returning same status code as fetched (issue1811042)

2010-07-15 Thread gagan . goku
On 2010/07/15 05:29:40, gagan.goku wrote: On 2010/07/15 05:27:09, gagan.goku wrote: reverting ProxyingContentRewriter Comments addressed. And to emphasize how important http status codes are, Rietveld is throwing 500 Server Error when i try to Publish+Mail comments. On 2010/07/14

Re: [SHINDIG-1382] Disable HttpClient cookie handling (issue1825042)

2010-07-15 Thread henry . saputra
LGTM http://codereview.appspot.com/1825042/show

Re: Adding DomainBalancingUriRe (issue1674041)

2010-07-15 Thread gagan . goku
Hi John Addressed your comments. Please take another look. For now, i have not bound ProxyUriManager to DomainBalancingProxyUriManager, though i did test it with 0.localhost and 1.localhost and it seemed to be generating the desired html. If possible, I would like to take that up in the

Re: SHINDIG-1378: Caja removes unknown attributes in os:PeopleSelector (issue1715049)

2010-07-15 Thread chiragshah1
http://codereview.appspot.com/1715049/show

Re: Handling post requests for Accel servlet (issue1822041)

2010-07-15 Thread John Hjelmstad
Hey Gagan: Thanks for the responses. Brief comments inline, then continuing the review. On Wed, Jul 14, 2010 at 11:20 PM, gagan.g...@gmail.com wrote: http://codereview.appspot.com/1822041/diff/33001/34001 File main/java/org/apache/shindig/gadgets/http/HttpRequest.java (right):

Re: json vs json-simple

2010-07-15 Thread Han Nguyen
The open source clearance for the replacement JSON library is taking us more than expected. We anticipate to contribute the code mid September. https://issues.apache.org/jira/browse/SHINDIG-1342 Han From: Pablo Graña pablo.gr...@globant.com To: dev@shindig.apache.org Date: 07/14/2010

Re: Remove unneeded @imports handling (issue1852041)

2010-07-15 Thread johnfargo
http://codereview.appspot.com/1852041/diff/1/4 File java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssParser.java (right): http://codereview.appspot.com/1852041/diff/1/4#newcode56 java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssParser.java:56: *