Re: Issue 2136044: Adding static files back to shindig jar

2010-09-10 Thread Gagandeep singh
Hi Paul I don't have much idea about the container / gadget related javascript and html files. Could you point me to some documentation / commits that can help me get more idea. Did you mean something like: 1) remove the files content/container/cookiebaseduserprefstore.js and other similar files

Load cajita-debugmode.js if debug=1 (issue2175042)

2010-09-10 Thread chiragshah1
Reviewers: jasvir, dev_shindig.apache.org, Description: This change introduces the feature caja-debug which is loaded by CajaContentRewriter if debug mode is enabled. Make CajaContentRewriter#cajaEnabled protected since subclasses may have different requirements for enabling/disabling caja. Ple

[RESULT] Release Apache Shindig Version 2.0.0

2010-09-10 Thread Paul Lindner
The vote to release shindig 2.0.0 is approved. +1 Paul, Vincent, Chico, Han, Bastian no 0 or -1 votes. Thanks everyone! For next steps I will promote the staging repo, update the download directory and update the website with the new information. Please note that I updated trunk to pull in th

Re: Cleaning up javascript with Closure Linter

2010-09-10 Thread Gagandeep Singh
The patch looks good. A script to split all the files into multiple codereviews could be helpful here. Thanks Gagan On Fri, Sep 10, 2010 at 4:33 PM, Paul Lindner wrote: > A while back I had started cleaning up the javascript code base to use > improved JsDoc annotations. > > Recently the Clo

Re: Cleaning up javascript with Closure Linter

2010-09-10 Thread Pablo GraƱa
There is also jslint, that can be run from a maven plugin. It does not modifies the code, just reports on practicese, as checkstyle or findbugs. On Fri, Sep 10, 2010 at 8:03 AM, Paul Lindner wrote: > A while back I had started cleaning up the javascript code base to use > improved JsDoc annotati

Cleaning up javascript with Closure Linter

2010-09-10 Thread Paul Lindner
A while back I had started cleaning up the javascript code base to use improved JsDoc annotations. Recently the Closure Linter was released: http://code.google.com/closure/utilities/ I'd like to propose that we run all of the javascript code through fixjsstyle. A patch of this size causes coder