I am curious about how you (and Paul) solved the problem.
Geald
On Mon, Oct 4, 2010 at 12:37 PM, Han Nguyen wrote:
> Thanks Paul!
>
>
>
> From: Paul Lindner
> To: dev@shindig.apache.org
> Date: 10/03/2010 11:45 AM
> Subject: Re: xmlParserAPIs.jar and xml-apis.jar cause class load
It seems that shindig 2.0 implements OpenSocial 1.0.
For rpc feature described on page
http://opensocial-resources.googlecode.com/svn/spec/1.0/Core-Gadget.xml#gadgets.rpc,
it says
"Provides operations for making remote procedure calls for
gadget-to-container, container-to-gadget, and gadget-to-
On 2010/10/05 01:02:01, chirag wrote:
http://codereview.appspot.com/2119043/diff/63001/java/common/conf/shindig.properties
File java/common/conf/shindig.properties (right):
http://codereview.appspot.com/2119043/diff/63001/java/common/conf/shindig.properties#newcode155
java/common/conf/shindi
Wouldn't Google Guice annotations[1] would solve this problem. Example
Bind:
bind(GadgetHtmlParser.class)
.annotatedWith(Names.named("parser-accel"))
.to(CajaHtmlParser.class);
Inject:
@Inject
public Accel(@Named("parser-acce") GadgetHtmlParser parser, ...
http://code.goog
http://codereview.appspot.com/2119043/diff/63001/java/common/conf/shindig.properties
File java/common/conf/shindig.properties (right):
http://codereview.appspot.com/2119043/diff/63001/java/common/conf/shindig.properties#newcode155
java/common/conf/shindig.properties:155: shindig.html.parser=neko
Build looks nice.
Committed as r1004328
http://codereview.appspot.com/2085042/
I would argue that this break encapsulation.
The idea is that ProxyHandler can be used by other services not just
ProxyServlet (i.e. GadgetHandler).
So the ProxyHandler should handle any User-Agent value, and if needed to
pass more info down, then maybe ProxyUri is the place to change.
http://c
Thanks Paul!
From: Paul Lindner
To: dev@shindig.apache.org
Date: 10/03/2010 11:45 AM
Subject:Re: xmlParserAPIs.jar and xml-apis.jar cause class loader
issue.
I just committed a fix for this to trunk. I'll make sure it gets
ported to 2.0.1
On Fri, Oct 1, 2010 at 8:34 PM, Ha
Thanks Paul.
On 4 October 2010 21:39, Paul Lindner wrote:
> k thx, ship it!
>
>
> On Mon, Oct 4, 2010 at 8:49 AM, Gagandeep singh
> wrote:
> >
> http://codereview.appspot.com/2085042/diff/27001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ConcatVisitorTest.java
> > has nice tes
k thx, ship it!
On Mon, Oct 4, 2010 at 8:49 AM, Gagandeep singh wrote:
> http://codereview.appspot.com/2085042/diff/27001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ConcatVisitorTest.java
> has nice tests for conditional and non conditional comments.
>
> On Mon, Oct 4, 2010 at
http://codereview.appspot.com/2085042/diff/27001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ConcatVisitorTest.javahas
nice tests for conditional and non conditional comments.
On Mon, Oct 4, 2010 at 9:05 PM, wrote:
> lgtm, if you could add a follow-on test for conditional comme
lgtm, if you could add a follow-on test for conditional comments I'd
appreciate it.
http://codereview.appspot.com/2085042/
Reviewers: *...@shindig.apache.org*,
Description:
Currently ProxyHandler just takes in the proxyUri to fetch and totally ignores
the http request headers like "User-Agent".
This change passes on the HttpRequest object which has all the headers present
in original request - Host and Content-Lengt
Reviewers: dev-remai...@shindig.apache.org,
Description:
Adding a GadgetHtmlParserRouter which can route to Caja / Neko parser based on
how its is configured.
This allows us to do stuff like:
@Override
public Document parseDomForEncodingDetection(String source) throws
GadgetException {
f
Can you open a jira issue with this information so that it doesn't get
forgotten. I'd like to see a solution, just don't have the time to
tackle it myself at the moment.
2010/9/23 Pablo Graña :
> Here is more info on the problem and the current status:
>
> http://code.google.com/p/guava-librarie
Reviewers: *...@shindig.apache.org*,
Description:
Single JS/CSS resources should be able to concatenate with themselves. This
behavior should be similar to ProxyingVisitor proxying single JS/CSS
resources.
This will be useful in cases when ScriptConcatContentRewriter and/or
StyleConcatContentRew
On a side not, i have a pretty decent intellij workflow described here:
https://docs.google.com/document/d/1uMf17Bli-CdOnfQGvJhpWED827noikrXBtrP5cb3b9s/edit?hl=en&pli=1#
On Mon, Oct 4, 2010 at 1:25 PM, Paul Lindner wrote:
> I've seen this in the past where Eclipse will reference the jar files
>
It should be complete (we run the unit tests after all) If you get a
runtime error could you file a bug at https://issues.apache.org/jira/
Thanks!
2010/9/29 王磊 :
> Hi folks,
>
> I was trying to replace the default JSON db sample with the JPA sample
> module which I checked out from svn, however
I've seen this in the past where Eclipse will reference the jar files
in the classpath instead of the workspace. I don't have a specific
answer for you. As I recall I ended up having to build/deploy from
Eclipse to solve this particular issue. Another option may be to use
remote debugging with.
I created ticket https://issues.apache.org/jira/browse/SHINDIG-1439
for the shutdown hook.
I read a little bit more about thread locals, and I think that caching
the DocumentBuilder in a ThreadLocal should not create a memory leak.
See this blog post:
http://blog.crazybob.org/2006/07/hard-core-jav
Hi Han,
If you check it into trunk I can merge it to 2.0.x branch. (Still
finalizing 2.0.1 release..)
On Fri, Oct 1, 2010 at 9:12 PM, Han Nguyen (JIRA) wrote:
>
> [
> https://issues.apache.org/jira/browse/SHINDIG-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&fo
Description:
Optimization:
Updated few checks in ConcatVisitor, to increase its coverage.
In getNextSibling() function:
1) We can be ignore are text node irrespective of their content.
2) We can ignore comment nodes expect for conditional comments.
Please review this at http://codereview.appspot.
22 matches
Mail list logo
