Re: Setting return-original-content-on-error for accel container (issue2646041)

2010-10-26 Thread gagan . goku
http://codereview.appspot.com/2646041/

Re: Setting return-original-content-on-error for accel container (issue2646041)

2010-10-26 Thread gagan . goku
Thanks Paul. Fixed DefaultAccelUriManagerTest.java in this patch as i had missed out the small change. Build looks nice now. Committed as r1027824. http://codereview.appspot.com/2646041/

Re: Setting return-original-content-on-error for accel container (issue2646041)

2010-10-26 Thread plindner
lgtm++ http://codereview.appspot.com/2646041/

Re: Use BasicContainerConfig in tests instead of AbstractContainerConfig (issue2724041)

2010-10-26 Thread johnfargo
LGTM, committed as r1027778. Thanks! On 2010/10/26 22:53:38, jtarrio wrote: Incorporate John's comments to my previous patch, update tests http://codereview.appspot.com/2724041/

Re: [VOTE] Release Apache Shindig Version 2.0.1

2010-10-26 Thread Han Nguyen
+1 Thanks Paul! From: Pablo Graña To: dev@shindig.apache.org Date: 10/26/2010 03:25 PM Subject:Re: [VOTE] Release Apache Shindig Version 2.0.1 +1 On Tue, Oct 26, 2010 at 3:56 PM, Paul Lindner wrote: > Hi, > > I built shindig 2.0.2 off the 2.0.x branch and am reopening the v

Re: [VOTE] Release Apache Shindig Version 2.0.1

2010-10-26 Thread Pablo Graña
+1 On Tue, Oct 26, 2010 at 3:56 PM, Paul Lindner wrote: > Hi, > > I built shindig 2.0.2 off the 2.0.x branch and am reopening the vote. > > 2.0.2 only contains a fix for the build-issue discovered by clirr > > The new staging repo: > https://repository.apache.org/content/repositories/orgapacheshi

Re: [VOTE] Release Apache Shindig Version 2.0.1

2010-10-26 Thread Paul Lindner
Hi, I built shindig 2.0.2 off the 2.0.x branch and am reopening the vote. 2.0.2 only contains a fix for the build-issue discovered by clirr The new staging repo: https://repository.apache.org/content/repositories/orgapacheshindig-003/ Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 On Fri, Oct 8

Re: Setting return-original-content-on-error for accel container (issue2646041)

2010-10-26 Thread plindner
lgtm http://codereview.appspot.com/2646041/

Issue 2727042: Making AccelHandler.fetch() public

2010-10-26 Thread Gagandeep singh
Reviewers: *...@shindig.apache.org* Description: Please review this at http://codereview.appspot.com/2727042/ Affected files: M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java Thanks Gagan

Issue 2646041: Setting return-original-content-on-error for accel container

2010-10-26 Thread Gagandeep singh
Reviewers: *...@shindig.apache.org* Description: Setting returnOriginalContentOnError true for accel container so that ProxyHandler does not throw exceptions and returns original content. When using VanillaCajaHtmlParser, we see the following exception on some pages: org.apache.shindig.gadgets.

Re: pubsub-2 subscribe to *

2010-10-26 Thread Eric Woods
Thanks, Javier. Subscribing to the double asterisks, **, works.

Re: pubsub-2 subscribe to *

2010-10-26 Thread Mark Weitzel
Javier just pointed out the proper use of the wild cards. The following is in both the OS 1.1 and OpenAjax specs. "Wildcards usage on topic subscription: Valid wild cards are "*" for single token and "**" for multiple token." -mw On Sat, Oct 23, 2010 at 8:32 PM, Paul Lindner wrote: > You might