Re: Review Request: Enable closure compiler by default

2011-07-21 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1179/#review1165 --- Some initial nits -- please consult with fargo about this... - Paul

Re: Review Request: Enable closure compiler by default

2011-07-21 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1179/#review1164 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Review Request: Enable closure compiler by default

2011-07-21 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1179/ --- Review request for shindig. Summary --- Enable closure with simple optimiza

Re: Security token on iframe URL

2011-07-21 Thread daviesd
Jasha, I am seeing exactly the same thing now that I've enabled "secure". The encodeToken in BlobSecurityTokeCodec throws an exception because the token is of type Proxy and not BlobCrypterSecurityToken. Not sure how to get this cast so that it can be encrypted. This only happened once I used a

Re: Code review request for View Enhancements To Open Gadgets and URLs (issue4641058)

2011-07-21 Thread jasonchiangc
minor update, add more error checking http://codereview.appspot.com/4641058/

Re: Common container rpc request uses wrong security token

2011-07-21 Thread daviesd
Ryan, I agree that the security token in the gadget holder should be done on the navigate. It appears this was the intention, but I think there are a few things about security tokens that havenĀ¹t been completed in the common container (I wish these holes were documented). My first attempt WAS to