Re: Example implementation for user prefs?

2011-07-28 Thread Craig McClanahan
On Thu, Jul 28, 2011 at 6:18 PM, Ryan J Baxter wrote: > I know iGoogle's container stores preferences per user per application > instance. Not sure if thats worth anything though, sine the spec does not > provide details on this. We also plan on having an implementation where > user prefs are p

Re: Example implementation for user prefs?

2011-07-28 Thread Ryan J Baxter
I know iGoogle's container stores preferences per user per application instance. Not sure if thats worth anything though, sine the spec does not provide details on this. We also plan on having an implementation where user prefs are per user per application instance. -Ryan Email: rjbax...@us.

Re: Example implementation for user prefs?

2011-07-28 Thread Henry Saputra
Hmm I cant seem to find if user preference is per application instance. I always assume that its per user/per application. - Henry On Wed, Jul 27, 2011 at 10:21 AM, Ciancetta, Jesse E. wrote: > I believe appdata is stored per user/per application as opposed to per > user/per application instanc

Re: Example implementation for user prefs?

2011-07-28 Thread Ryan J Baxter
Doug can you explain more about how your using appdata + site id to store user prefs? I tried looking below but couldn't find an explanation. I realize that every gadget site has a unique gadget id, but couldn't a container choose to reuse a gadget site? Say a container renders gadget 1 in s

Re: javascript readability..

2011-07-28 Thread John Hjelmstad
Hey Jesse, Interesting idea here -- this sounds suspiciously akin to the functionality already present in exportJs(...) used for exporting symbols. This method upserts the namespace in much the same way as your helper method does. Thoughts on whether we could reuse or augment that? -j On Thu, Ju

Re: javascript readability..

2011-07-28 Thread John Hjelmstad
Hey Jesse, Interesting idea here -- this sounds suspiciously akin to the functionality already present in exportJs(...) used for exporting symbols. This method upserts the namespace in much the same way as your helper method does. Thoughts on whether we could reuse or augment that? -j On Thu, Ju

Re: [RESULT] Ryan Baxter as Apache Shindig Committer

2011-07-28 Thread Henry Saputra
Congrats Ryan! - Henry On Thu, Jul 28, 2011 at 8:45 AM, Paul Lindner wrote: > The votes are in and Ryan Baxter is has been approved as an Apache Shindig > committer. > > +1 - 7 total [Paul, Henry, Jasvir, Michael, Chich, Eric, Han] > -1 - 0 > > Congratulations Ryan! > > -- > Paul Lindner -- lind

Re: Review Request: Don't inject ___jsl.u if there's no non-empty value to inject.

2011-07-28 Thread johnfargo
> On 2011-07-26 22:01:08, Jasvir Nagra wrote: > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJslInfoVariableProcessor.java, > > line 63 > > > > > > What prevents features from containing a ']' chara

Are more dependency upgrades planned for Shindig 3.0.0?

2011-07-28 Thread Matthew G Marum
Do people have Java dependency changes that they know they need to get in before the GA of Shindig 3.0.0? Obviously, not every change can be anticipated but if there's something in the pipe, we'd love to get a heads up about it. Matt Marum

Re: [RESULT] Ryan Baxter as Apache Shindig Committer

2011-07-28 Thread Ryan J Baxter
Thanks everyone! -Ryan Email: rjbax...@us.ibm.com Phone: 978-899-3041 developerWorks Profile From: Paul Lindner To: dev@shindig.apache.org, Cc: priv...@shindig.apache.org Date: 07/28/2011 11:45 AM Subject:[RESULT] Ryan Baxter as Apache Shindig Committer The votes are i

Re: Review Request: Improve exportJs() in the face of potentially non-existent symbols.

2011-07-28 Thread Michael Hermanto
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1199/#review1210 --- Ship it! (possibly repeating here) Can you also ensure that {gadgets:

Re: Review Request: Improve exportJs() in the face of potentially non-existent symbols.

2011-07-28 Thread Michael Hermanto
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1199/#review1209 --- - Michael On 2011-07-26 21:26:55, johnfargo wrote: > >

Re: Example implementation for user prefs?

2011-07-28 Thread daviesd
Argh... Nevermind... I wasn't removing my up_siteid_ prefix from the get_pref value before returning it. This is working beautifully Dan. Nice job! doug On 7/28/11 12:19 PM, "daviesd" wrote: > Dan, > > Are you sure about this? I am having an issue now where I've implemented the > plugin po

Re: Example implementation for user prefs?

2011-07-28 Thread daviesd
Dan, Are you sure about this? I am having an issue now where I've implemented the plugin points you've provided but the gadget isn't recognizing the userprefs once set. I'm pretty sure I need them at metadata time. doug On 7/27/11 3:41 PM, "Dan Dumont" wrote: > Correction: the preferences

Re: Example implementation for user prefs?

2011-07-28 Thread daviesd
Jesse, I think you are correct that it should be per instance. That's where the siteid would come into play. At least that's how I'm reading it (and now implementing it). In our case a particular gadget always renders in the same siteid. Two instances of the same gadget would have different site

RE: Example implementation for user prefs?

2011-07-28 Thread Ciancetta, Jesse E.
>If you wish to persist preferences for a particular occurrence of a >gadget(per gadget url instance), then you'll need to keep track of the >site (the auto generated ids are less helpful), if you wish to provide >"per gadget url" preferences you can just ignore they siteid and return or >persist t

[RESULT] Ryan Baxter as Apache Shindig Committer

2011-07-28 Thread Paul Lindner
The votes are in and Ryan Baxter is has been approved as an Apache Shindig committer. +1 - 7 total [Paul, Henry, Jasvir, Michael, Chich, Eric, Han] -1 - 0 Congratulations Ryan! -- Paul Lindner -- lind...@inuus.com -- linkedin.com/in/plindner

Re: Example implementation for user prefs?

2011-07-28 Thread daviesd
Dan, Thanks. This is working for the most part, however I'm having issues with the GET_PREFERENCES function. In my implementation I need to gadget site (not just the id) so I do var site = self.sites_[siteId]; This returns me the right site, however then when I go to get the gadget holder var

RE: javascript readability..

2011-07-28 Thread Ciancetta, Jesse E.
I agree with John -- I also prefer the first style Paul presented (which I believe is also the most prevalent style in Shindig currently). With respect to the issues that Michael raised about building up a namespace from across different files -- this got me thinking about a little namespace ut