Re: makeRequest calls fail in commonContainer

2011-08-15 Thread Nuwan Bandara
hi Henry, On Mon, Aug 15, 2011 at 6:31 PM, Henry Saputra wrote: > Hi Nuwan, > > Did you see this error from running Shindig from trunk? > yes, r1157930 Regards, /Nuwan > > - Henry > > On Mon, Aug 15, 2011 at 4:25 PM, Nuwan Bandara > wrote: > > Hi, > > > > Is there a perticular reason why mak

Re: makeRequest calls fail in commonContainer

2011-08-15 Thread Henry Saputra
Hi Nuwan, Did you see this error from running Shindig from trunk? - Henry On Mon, Aug 15, 2011 at 4:25 PM, Nuwan Bandara wrote: > Hi, > > Is there a perticular reason why makeRequest calls faill in commonContainer. > > i.e. If you try the horoscope gadget [1] in > http://localhost:8080/sampleco

makeRequest calls fail in commonContainer

2011-08-15 Thread Nuwan Bandara
Hi, Is there a perticular reason why makeRequest calls faill in commonContainer. i.e. If you try the horoscope gadget [1] in http://localhost:8080/samplecontainer/examples/commoncontainer/ it fails saying invalid URL parameter. from the looks of it the secureToken is not sent with requests; howev

Re: Review Request: Bug fix for openEE implementation in open-views feature and change the scrolling settings in container.url feature

2011-08-15 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1505/#review1463 --- LGTM, could you please create a JIRA for this? - Ryan On 2011-08-15

Re: Review Request: Fix to support for VIEW and VIEW_TARGET in actions feature

2011-08-15 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1201/#review1456 --- Ship it! LGTM small nit around extra spaces in but I removed them bef

Re: Review Request: Change the GET_PREFERENCES api to be asynchronous

2011-08-15 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1476/#review1455 --- Ship it! Committed revision 1157893. - Ryan On 2011-08-11 23:35:43

Re: Review Request: Fix to support for VIEW and VIEW_TARGET in actions feature

2011-08-15 Thread Matthew Hatem
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1201/ --- (Updated 2011-08-15 15:08:16.073843) Review request for shindig, Ryan Baxter and

RE: Review Request: Enable loading security token key from either an absolute filesystem reference or from the classpath

2011-08-15 Thread Ciancetta, Jesse E.
Thanks Henry and Paul! I've gone ahead and closed out the review request as submitted. >-Original Message- >From: Henry Saputra [mailto:henry.sapu...@gmail.com] >Sent: Friday, August 12, 2011 10:55 PM >To: dev@shindig.apache.org >Subject: Re: Review Request: Enable loading security token