Re: Review Request: Fixes to actions feature to match spec (runAction and registerXHandler).

2011-08-18 Thread Matthew Hatem
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1533/ --- (Updated 2011-08-19 01:53:08.369683) Review request for shindig and Ryan Baxter.

Re: Review Request: Fixes to actions feature to match spec (runAction and registerXHandler).

2011-08-18 Thread Henry Saputra
> On 2011-08-17 22:14:53, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js, > > line 251 > > > > > > Same here the function is called registerH

Re: Review Request: Fixes to actions feature to match spec (runAction and registerXHandler).

2011-08-18 Thread Matthew Hatem
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1533/ --- (Updated 2011-08-19 00:33:54.116967) Review request for shindig and Ryan Baxter.

Re: Review Request: Fixes to actions feature to match spec (runAction and registerXHandler).

2011-08-18 Thread Matthew Hatem
> On 2011-08-17 22:14:53, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js, > > line 90 > > > > > > Is it possible for actions not

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-18 Thread Henry Saputra
> On 2011-08-16 17:24:01, Henry Saputra wrote: > > Please attach the final patch to the jira entry. - Henry --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1525/#review1479 --

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-18 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1525/#review1527 --- Ship it! Thanks for the explanation Dan. LGTM. +1 - Henry On 2011-

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-18 Thread Jesse Ciancetta
> On 2011-08-16 17:24:01, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.onload/onload.js, > > line 47 > > > > > > Why does the definition registerOn

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-18 Thread Dan Dumont
> On 2011-08-16 17:24:01, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.onload/onload.js, > > line 47 > > > > > > Why does the definition registerOn

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-18 Thread Henry Saputra
> On 2011-08-16 17:24:01, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.onload/onload.js, > > line 47 > > > > > > Why does the definition registerOn

Re: [IMPORTANT] Submitting patches to Shindig

2011-08-18 Thread Henry Saputra
Hi Stanton, Good question and I am not sure about it. Maybe Paul could help me with previous issues. But I think as long as the individuals that submit patches have signed ICL/CLA to grant the patches to be used with ASF license we should be alright. - Henry On Thu, Aug 18, 2011 at 11:42 AM, St

Re: [IMPORTANT] Submitting patches to Shindig

2011-08-18 Thread Stanton Sievers
Hi Henry, Does this mean that all JIRAs need to be retroactively updated with a patch and authorization for inlusion in ASF works? Thanks, -Stanton From: Henry Saputra To: dev@shindig.apache.org, Date: 08/18/2011 13:57 Subject:[IMPORTANT] Submitting patches to Shindig As

[IMPORTANT] Submitting patches to Shindig

2011-08-18 Thread Henry Saputra
As Paul has mentioned in his email below to make sure ASF has clearance to include your code in the absence of signed ICLA/CLA I forgot to mention that to make sure that the final patch attached to your JIRA case. When you attaching patch to JIRA it will ask you to "Grant license to ASF for inclusi

Re: Review Request: enable osapi.endpoints to support both http and https

2011-08-18 Thread Eric Woods
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1578/#review1519 --- Ship it! Looks good to me; patch applied. Thanks, Li. - Eric On 2

Re: Review Request: enable osapi.endpoints to support both http and https

2011-08-18 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1578/ --- (Updated 2011-08-18 15:29:38.309795) Review request for shindig, Paul Lindner, H