Review Request: Remove Quirks Mode PHP Implementation

2011-08-25 Thread Bastian Hofmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1655/ --- Review request for shindig. Summary --- See

Re: Call For Implementors

2011-08-25 Thread Bastian Hofmann
I started with implementing the removal of quirks mode default in PHP: https://issues.apache.org/jira/browse/SHINDIG-1595 I should be able to start working on the OAuth 2 stuff next week, but I can not make a detailed estimate yet on how much time I'll be able to invest. -- Bastian On Tue, Aug

Re: Review Request: Issue in recent callSameDomain rpc changes when not using same domain

2011-08-25 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1635/ --- (Updated 2011-08-25 13:09:16.383370) Review request for shindig. Changes

Re: Review Request: Allow for incremental preloading of gadget metadata and security tokens

2011-08-25 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1563/#review1639 --- The code itself is fine with one small nit. Just for my

Re: Review Request: Remove Quirks Mode PHP Implementation

2011-08-25 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1655/#review1640 --- /trunk/php/src/gadgets/render/GadgetHtmlRenderer.php

Re: Review Request: Remove Quirks Mode PHP Implementation

2011-08-25 Thread Bastian Hofmann
On 2011-08-25 14:21:43, Henry Saputra wrote: /trunk/php/src/gadgets/render/GadgetHtmlRenderer.php, line 44 https://reviews.apache.org/r/1655/diff/1/?file=35515#file35515line44 Is this to check if view name requested is quirks? No, in the PHP implementation so far you could add a

Re: Review Request: Allow for incremental preloading of gadget metadata and security tokens

2011-08-25 Thread Jesse Ciancetta
On 2011-08-25 13:15:21, Ryan Baxter wrote: The code itself is fine with one small nit. Just for my understanding, I assume there is a reason why you need to create the container object before you have the metadata you want to cache. How are you generating the metadata, or is this

Re: Review Request: Allow for incremental preloading of gadget metadata and security tokens

2011-08-25 Thread Jesse Ciancetta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1563/ --- (Updated 2011-08-25 15:32:43.908637) Review request for shindig. Changes

Re: Review Request: Remove Quirks Mode PHP Implementation

2011-08-25 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1655/#review1648 --- Ship it! +1 - Henry On 2011-08-25 12:02:06, Bastian Hofmann

RE: Review Request: Common container currently doesnt include the siteId (moduleId) in any of it's security token processing/handling

2011-08-25 Thread Ciancetta, Jesse E.
Just to try to start some kind of dialog around this... Do people think it's important to have correct moduleId's in security tokens? And just to be clear -- I mean that as a real question -- I'm not trying to be flip... If people using common container are only using security tokens for