RE: Review Request: Allow for incremental preloading of gadget metadata and security tokens

2011-09-13 Thread Ciancetta, Jesse E.
*bump* I've had a few common container related patches open on the review board for close to a month now -- could I trouble the Shindig committers to please help me see them through? I (and the Apache Rave community who are waiting on these patches) would very much appreciate it! Please see

Re: Review Request: Allow for custom security token fetch function to be used when refreshing security tokens

2011-09-13 Thread Mat Mannion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1564/#review1872 --- Ship it! LGTM - Mat On 2011-08-17 18:17:48, Jesse Ciancetta

osapi services and asychronous calls

2011-09-13 Thread daviesd
We¹ve implemented our own userprefs osapi service (yes, we dumped the whole idea of sitting on top of appdata). As I understand it the calls to our service will be asynchronous. Recently Dan Dumont made some changes to the common container layer to support a callback for GET_PREFERENCES so that

Re: Review Request: shared-script-frame feature

2011-09-13 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1749/ --- (Updated 2011-09-13 18:09:05.479371) Review request for shindig, johnfargo,

Re: Review Request: shared-script-frame feature

2011-09-13 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1749/#review1870 --- One nit, I am not to fond of the feature name 'script-frame'. From

Re: Review Request: Allow for custom security token fetch function to be used when refreshing security tokens

2011-09-13 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1564/#review1878 --- Ship it! +1 Will commit this from JIRA patch unless anyone object.